Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong code generated with custom slice types #139

Open
millerlogic opened this issue Feb 22, 2020 · 0 comments
Open

wrong code generated with custom slice types #139

millerlogic opened this issue Feb 22, 2020 · 0 comments

Comments

@millerlogic
Copy link

Running this code on the codegen

package asdf

type MyInt int

type MySlice []MyInt

type Foo struct {
        Field MySlice
}

gojay -s ./asdf.go -p true -pkg asdf -t Foo

It generates code with the following:

type MySlices MySlice

func (s *MySlices) UnmarshalJSONArray(dec *gojay.Decoder) error {
	var value = {}
	if err := dec.Object(&value); err != nil {
		return err
	}
	*s = append(*s, value)
	return nil
}

Notice the var value = {} the type is incorrect (though the whole command fails because it chokes on gofmt)

Quickly looking through the code, it looks like ComponentInit is {} (and ComponentType may be empty) for the HelperType.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant