Skip to content

Latest commit

 

History

History
82 lines (57 loc) · 2.82 KB

CONTRIBUTING.md

File metadata and controls

82 lines (57 loc) · 2.82 KB
Raw

Contribution Guidelines

## Creating issues

Issues should be made by using the issue tracker.

Things to remember:

  • Be descriptive
  • Be respectful of others

Languages

When needing to add labels, placeholders or general text, you must not write directly into the source file, rather make use of the ./app/lang/ directory. Always provide the English translation and copy your English string to all other languages - making sure that the indentation and alignment of the arrays are updated.

Coding Standards

Please follow existing coding standards:

<?php

namespace Foo\Bar\Controller;

use Foo\Bar\Bar;

class Foo extends Bar
{
    public function baz()
    {
        if ($condition) {
        }
    }
}
  • At least one newline separating namespace, use, function and class declarations.
  • Spaces around operators, loops, conditions and control blocks: 
    <?php
use \Exception;

if ($condition === (10 + 2)) {
    try {
        throw Exception("Something went wrong...");
    } catch (Exception $e) {
        // Do something here.
    }
}
  • Braces on a new line following: namespace, use, function and class.
  • Line lengths have a soft 80 limit and hard 120 length.
  • PHP constants should be in lowercase; true, false and null.
  • Defined constants should always be in uppercase.
  • Never leave trailing spaces at the end of a line.
  • Files should end with one blank line.
  • Do not use # Bash style comments.
  • Always add or update Docblocs to functions.
  • If your pull request consists of more than two commits, you must squash them into one.

If you're still unsure, then take a look at existing code.

Introduction into to Git and GitHub

If you are new to Git, GitHub and the whole open source software community, welcome! Here are some resources for getting started and understanding what it's all about.

If you're not particularly fond of the command line, you can get one of GitHub's free GUI desktop apps:

If you're feeling adventurous, you can become a Git & GitHub master with the Git Path on Code School.

There is always the Cachet Gitter chat to ask any questions you may have:

![Gitter](https://badges.gitter.im/Join Chat.svg)

You should also make use of the .editorconfig file found within the root of the repository. It'll make sure that your editor is setup with the same file settings.