Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to the League? #21

Open
assertchris opened this issue May 14, 2015 · 17 comments
Open

Move to the League? #21

assertchris opened this issue May 14, 2015 · 17 comments

Comments

@assertchris
Copy link

See https://groups.google.com/forum/#!searchin/thephpleague/architect/thephpleague/f0ynLoxRpvQ/dTBz3Zi8bAUJ

@franzliedke
Copy link
Owner

Thanks for considering, I'm generally open for moving to the league. =)

Can you tell me a little more about what this would entail?

@assertchris
Copy link
Author

Moving stuff to the League is all about helping you to make a singular library even better. We all chip in to make sure the library stays alive, and that pull requests and issues don't go unanswered. When you need to take a break/go on a holiday/whatever, then we help with things.

There are a few code/repository requirements; like setting up CI and having a level of test coverage. I'll submit pull request(s) for much of the code-related stuff, but a significant code change is that League packages have League as the vendor (in namespaces).

@RemiCollin
Copy link
Contributor

👍

Moving to the League would provide more exposure, which is a good thing.

@swt83
Copy link

swt83 commented May 23, 2015

Don't let "the League" steal your glory. You built this.

@assertchris
Copy link
Author

@swt83 that's a tad dramatic. Its not a change of ownership, it's a promotional platform and support network.

@spamoom
Copy link

spamoom commented Oct 12, 2015

+1 for this, it's a hidden gem that would definitely get much much more exposure being part of League

@franzliedke
Copy link
Owner

Thanks for the kind words, @spamoom. 👍

Once I finish my master thesis (about a month to go), I'll follow up on this. :)

@spamoom
Copy link

spamoom commented Oct 16, 2015

Happy to help if I can!

@franzliedke
Copy link
Owner

@assertchris Still interested in this?

I achieved a major breakthrough for the next (major-ish) version yesterday, by getting my PR merged into Composer. Studio now does something much less hack-ish, but far more magical, by dynamically generating Composer path repositories, all without touching the composer.json file. This means, package maintainers can benefit from this kind of setup without having to change anything in the files managed by Git.

@franzliedke
Copy link
Owner

In any case, how would we proceed? I'm about to release an 1.0 version, would the move to the League need to happen before doing so?

@assertchris
Copy link
Author

Hey @franzliedke. I'd love to work on this but right now I have negative time to. The move to league doesn't have to happen before you tag 1.0, but it will be a breaking change (major version bump, according to semver) when it does happen.

@franzliedke
Copy link
Owner

I wonder how important BC is for such a package, since it's not a library, but rather a tool to be installed globally using Composer (even if it's installed only for a project, it's only the bin/studio file that people interact with).

@RemiCollin
Copy link
Contributor

@franzliedke Is the new version testable yet ?

@franzliedke
Copy link
Owner

Weeeeelll... the code is object-oriented. So it is testable, but not tested.

Also, most of it is in console commands, where I didn't know how to best test those. Any clues? Feel free to open an issue about that.

@RemiCollin
Copy link
Contributor

Oh I actually meant 'real-life' testable, with the last version of composer.

@franzliedke
Copy link
Owner

Oh that, yes, please test it out. Make sure Composer is up-to-date (a version from today or yesterday) and use Studio's latest dev-master. It works well for me and my large Flarum dev setup.

@grobmeier
Copy link

Moving a library like this to League (or another Foundation) often helps to keep it alive, even when the original maintainer does not want to work on it further. But it's no guarantee. I have seen tiny projects fail, because nobody at a Foundation felt responsible (or had the time).

It would be the first project of this toolish kind. Might not mean anything.

Personally I like many league packages. Not all of them.

You would have some "community" which gives you a framework. This can be good or bad.

The other way would be to try build a community around Studio itself. I think it is hard, because I believe Studio should be a part of the Composer project itself, and the features should be available natively in Composer.

Whatever you do, keep up the great work. I will certainly follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants