Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Item-wise Sales and Purchase register with no item codes #41373

Closed
1 task
deepeshgarg007 opened this issue May 8, 2024 · 0 comments
Closed
1 task

fix: Item-wise Sales and Purchase register with no item codes #41373

deepeshgarg007 opened this issue May 8, 2024 · 0 comments
Assignees
@Poorvi-R-Bhat
Labels
bug good first issue Good issue for beginners.

Comments

@deepeshgarg007
Copy link
Member

deepeshgarg007 commented May 8, 2024 •
edited

Information about bug

ERPNext allows creation of Sales/Purchase Invoices without having an item master (item code) for petty income/expense
Such invoices are pulled in Sales and Purchase register not in item-wise sales and purchase register which leads to mis-match in both these reports

A possible solution for this could be to do a left join on the Sales Invoice/Sales Invoice Item table

Other ToDos:

  • Rewrite all the raw SQL queries using query builder
@deepeshgarg007 deepeshgarg007 added the good first issue Good issue for beginners. label May 8, 2024
Poorvi-R-Bhat added a commit to Poorvi-R-Bhat/erpnextdev that referenced this issue May 13, 2024
@Poorvi-R-Bhat
fix: Item-wise Sales and Purchase register with no item codes frappe#…
1b45ecf 
…41373
Poorvi-R-Bhat added a commit to Poorvi-R-Bhat/erpnextdev that referenced this issue May 22, 2024
@Poorvi-R-Bhat
fix: fixing Item-wise sales register and purchase register frappe#41373
76073ae
Poorvi-R-Bhat added a commit to Poorvi-R-Bhat/erpnextdev that referenced this issue May 22, 2024
@Poorvi-R-Bhat
fix: fixing Item-wise sales register frappe#41373
eafa88b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Poorvi-R-Bhat Poorvi-R-Bhat

Labels
bug good first issue Good issue for beginners.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Poorvi-R-Bhat @deepeshgarg007