You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For Journal Entry - Credit limit check does not account for bypass sales order amount flag.
`def check_credit_limit(self):
customers = list(
set(
d.party
for d in self.get("accounts")
if d.party_type == "Customer" and d.party and flt(d.debit) > 0
)
)
if customers:
from erpnext.selling.doctype.customer.customer import check_credit_limit
for customer in customers:
check_credit_limit(customer, self.company)`
For Sales Invoice, It has a flag check for bypass sales order level check
`def check_credit_limit(self):
from erpnext.selling.doctype.customer.customer import check_credit_limit
validate_against_credit_limit = False
bypass_credit_limit_check_at_sales_order = frappe.db.get_value(
"Customer Credit Limit",
filters={"parent": self.customer, "parenttype": "Customer", "company": self.company},
fieldname=["bypass_credit_limit_check"],
)
if bypass_credit_limit_check_at_sales_order:
validate_against_credit_limit = True
for d in self.get("items"):
if not (d.sales_order or d.delivery_note):
validate_against_credit_limit = True
break
if validate_against_credit_limit:
check_credit_limit(self.customer, self.company, bypass_credit_limit_check_at_sales_order)
`
JV check should be similar to Sales Invoice level credit limit check.
Same thing happens while changing the Credit Limit for a customer.
Module
accounts
Version
ERPNext: v15.22.1 (version-15)
Frappe Framework: v15.25.0 (version-15)
Installation method
manual install
Relevant log output / Stack trace / Full Error Message.
No response
The text was updated successfully, but these errors were encountered:
Information about bug
ERPNext: v15.22.1 (version-15)
Frappe Framework: v15.25.0 (version-15)
For Journal Entry - Credit limit check does not account for bypass sales order amount flag.
`def check_credit_limit(self):
customers = list(
set(
d.party
for d in self.get("accounts")
if d.party_type == "Customer" and d.party and flt(d.debit) > 0
)
)
if customers:
from erpnext.selling.doctype.customer.customer import check_credit_limit
For Sales Invoice, It has a flag check for bypass sales order level check
`def check_credit_limit(self):
from erpnext.selling.doctype.customer.customer import check_credit_limit
`
JV check should be similar to Sales Invoice level credit limit check.
Same thing happens while changing the Credit Limit for a customer.
Module
accounts
Version
ERPNext: v15.22.1 (version-15)
Frappe Framework: v15.25.0 (version-15)
Installation method
manual install
Relevant log output / Stack trace / Full Error Message.
No response
The text was updated successfully, but these errors were encountered: