Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Custom HTML Blocks to be Standard/stored in file system #26442

Open
ahassoun opened this issue May 15, 2024 · 4 comments
Open

Allow Custom HTML Blocks to be Standard/stored in file system #26442

ahassoun opened this issue May 15, 2024 · 4 comments

Comments

@ahassoun
Copy link

The Custom HTML Blocks feature is really helpful to build dynamic and rich Workspaces. Kudos to those who built this.

I strongly believe they should have the option to be Standard / shipped in a Custom App or stored in the file system for version control.

fixtures-export does not seem to be sufficient for such kinds of DocTypes.

@ankush
Copy link
Member

ankush commented May 16, 2024

fixtures-export does not seem to be sufficient for such kinds of DocTypes.

Why? 🤔

@ahassoun
Copy link
Author

Thank you for taking the time to review my suggestion.

fixtures-export does not seem to be sufficient for such kinds of DocTypes.

Why? 🤔

I might be using Git wrong, but for context, and in one project, we have close to 100 blocks live, and another dozen planned but not yet implemented.

export-fixtures worked well to ship the blocks across sites, but tracking files and changes for individual blocks wasn't straightforward, since all 100 blocks, * 3 (for HTML, CSS, and JS) are in one JSON file.

@ankush
Copy link
Member

ankush commented May 17, 2024

Yeah fixtures aren't something to look for if you want good diffs, but it gets the job done.

@ahassoun
Copy link
Author

Yeah fixtures aren't something to look for if you want good diffs, but it gets the job done.

Yes, that's my point. And also, and I believe more importantly, allows each developer to push specific blocks, instead of syncing the whole fixture file.

Additionally, please consider a medal for (App with Most Custom Blocks 🏆). The name can be changed later for a more creative one 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants