Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer tending guides' links outline is touching the text #622

Open
Sboonny opened this issue Mar 6, 2023 · 3 comments
Open

Footer tending guides' links outline is touching the text #622

Sboonny opened this issue Mar 6, 2023 · 3 comments

Comments

@Sboonny
Copy link
Member

Sboonny commented Mar 6, 2023

Edit: the issue has been changed in freeCodeCamp, I have transferred it here to start changing news here as well.

Describe the bug
While navigating the footer using the keyboard, the outline is touching the text, which doesn't look visually clean.

rec-tab.12.webm

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.freecodecamp.org/
  2. Click on tab until you reach the footer
  3. See outline

Expected behavior
the outline shouldn't touch the text

image

Additional context
the outline is touching the text because of this property

 .footer-col a {
    padding: 5px 0;
}

we can remove the 0 or add offset to the outline in the footer if it's a link. yes it's affect the tax link

image

@bbsmooth
Copy link

bbsmooth commented Mar 6, 2023

If I had to choose, I think the padding needs to be fixed instead of messing with the outline offset.

Also, I think these links need to be fixed so that their hover area doesn't extend past their text. This is especially noticeable in mobile view. The links are lined up in a single column on the left but you can move your mouse almost all the way to the right side of the window and still click the link. This can be especially annoying for touch users.

@Saikat-Mandal
Copy link

@bbsmooth are you working on this issue ?

@ahmaxed
Copy link
Member

ahmaxed commented Mar 8, 2023

Just a heads up, what ever we do here needs to also take place in /news and /forum since they share an identical footer style.

LAKSHAYNE referenced this issue in LAKSHAYNE/freeCodeCamp Apr 4, 2023
changed the padding from 5px 0 to 5px .footer-col a
@Sboonny Sboonny transferred this issue from freeCodeCamp/freeCodeCamp Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants