Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook doesn't apply the correct font family #121

Closed
huyenltnguyen opened this issue May 8, 2024 · 1 comment
Closed

Storybook doesn't apply the correct font family #121

huyenltnguyen opened this issue May 8, 2024 · 1 comment
Assignees
Labels
type: bug Something isn't working

Comments

@huyenltnguyen
Copy link
Member

Description

We added the font files (#100) as well as updating the Storybook config (#119) but Storybook isn't picking up the fonts still.

Screenshot 2024-05-08 at 14 04 07

I think this is because the font-family property is broken in global-element-styles.css:

  • There are two font-family rules set to the body:
  • The second overrides the first, but --font-family-sans-serif is not defined, so Storybook falls back to the a system font

I'm creating this ticket to track the issue, but I think #114 should resolve it.

@huyenltnguyen huyenltnguyen added the type: bug Something isn't working label May 8, 2024
@huyenltnguyen huyenltnguyen self-assigned this May 8, 2024
@huyenltnguyen
Copy link
Member Author

Closing as #114 has resolved the issue.

Storybook now displays the components with the correct font:

Screenshot 2024-05-20 at 13 06 53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant