Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change sass gradle plugin 8.3 to 8.4: embedded_protocol missing #915

Open
marco-schmidt opened this issue Oct 9, 2023 · 1 comment
Assignees

Comments

@marco-schmidt
Copy link

Hi, I've upgraded our usage of sass gradle plugin version 8.3 to 8.4 and got an error
Could not get unknown property 'embedded_protocol' for extension 'sass' ...

I searched for a while and replaced

sass {
    outputStyle = sass.embedded_protocol.EmbeddedSass.OutputStyle.EXPANDED

with

sass {
    outputStyle = com.sass_lang.embedded_protocol.OutputStyle.EXPANDED

and this seems to work.

Your documentation for 8.4 https://docs.freefair.io/gradle-plugins/8.4/reference/#_io_freefair_sass_base still has the old version in its example. I did not find the source for the docs, so I could not open a PR, maybe you can update it.

Thanks for providing the plugin,
Marco

@larsgrefer larsgrefer self-assigned this Oct 9, 2023
@larsgrefer
Copy link
Member

The source for the Docs is here:

outputStyle = sass.embedded_protocol.EmbeddedSass.OutputStyle.EXPANDED

With 8.4 we internally upgrade the embedded sass protocol to 2.x which now uses proper java packages

larsgrefer added a commit that referenced this issue Oct 10, 2023
larsgrefer added a commit that referenced this issue Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants