Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Balance visualization to Dashboard #1283

Open
VanessaE opened this issue May 29, 2023 · 6 comments
Open

Add Balance visualization to Dashboard #1283

VanessaE opened this issue May 29, 2023 · 6 comments
Labels
enhancement New feature or request Low prio Issues with low priority

Comments

@VanessaE
Copy link
Contributor

VanessaE commented May 29, 2023

Is your feature request related to a problem? Please describe.

No, not as such.

Describe the solution you'd like

It would be useful to have a copy of the Trade page's "Balance" visualization on the Dashboard page too.

Since that page may display multiple bots, you'll want to limit this copy of the visualization to its "show all bots" view mode.

Obviously there'd be no need to bother with that whole "multi pane" thing, I don't think the rest of its contents would be particularly useful in the Dashboard page.

Describe alternatives you've considered

Clicking back and forth between Trade and Dashboard is the only other solution I can see.

@xmatthias xmatthias added enhancement New feature or request Low prio Issues with low priority labels May 29, 2023
@xmatthias
Copy link
Member

While i've added this for now as "low prio" feature request, it's unlikely to be implemented (at least not in the way it's requested).

FreqUI supports bots with multiple different stake-currencies (USDT, BTC, ...) - showing them all in one table / chart will not really work.
Assuming we reduce it to the balance chart (the circle diagram) - it'd show you your assets, which sounds good at first, but fails in practice in too many scenarios (it's really useless to see 2 live bots together with 3 dry-run bots).

However limiting the view to live bots would be more than confusing - and wouldn't cover other usecases (where people are not yet in the "live" stage) - and would (in such a case) show no output whatsoever).


I'll keep this one open for now, and will be open for PR's, as well as input on how the problems pointed out in this comment could be solved.
If we get no ideas to solve the above problems, nor a PR, i'll however be closing this in a few months.

future reader: If you intend to submit a PR, please share your ideas on how to solve the above issues here first, so we can see together if they might work.

@VanessaE
Copy link
Contributor Author

VanessaE commented May 29, 2023

Seems to me that 99% of the potential problems you bring up could be solved by simply putting small tabs down one side of the pane, each referring to a specific bot. Click the tab, see that bot's balance and assets.

If you number the bots in the "Bot comparison" table, and put corresponding numbers on the tabs (i.e. no words or names), that would avoid using too much screen space. Tooltips could be used to identify which bot each tab represents, for those who don't understand the point of the numbers.

These tabs would be drawn similar to the buttons at the top of the existing Balance display, or they could just BE actual buttons. I only call them tabs because of how they would seem to behave. For the majority of users who would only be running one bot, you just wouldn't show any tabs/buttons (or any numbers in the "comparison" table).

This would also ensure that you can show both the "pie chart" and the asset listing normally shown below it.

As for live vs. dry run mode, just write "Dry run" in the center of the pie chart, if the bot that's being shown is in that mode.

@xmatthias
Copy link
Member

xmatthias commented May 29, 2023

if it's limited to 1 bot - then it provides nothing over the existing balance information, which is accessible and available for each individual bot in the Trades pane.

That's then no enhancement, just duplicate information, taking precious real-estate without providing any benefit.

We can eventually provide the double-click functionality in the bot comparison list which brings you to the corresponding trade pane (same as with the trades view we have already).

@VanessaE
Copy link
Contributor Author

VanessaE commented May 29, 2023

The benefit is that it would be on the same screen -- no need to click back and forth between Trade and Dashboard.

"Precious real estate" is not the argument you think it is. If the user doesn't want the Balance display to take up space, they can just move it to the bottom of the layout, where it'll be off-screen.

The same argument could be made for the lists of open and closed trades -- why are they useful on the Dashboard, but a balance display isn't?

@xmatthias
Copy link
Member

Open/closed trades provide a summary over all bots - which is where it brings benefits.
obviously if you only run one bot, you'll not see a benefit - but if you run multiple bots, seeing "i have 5 open trades over 3 bots" can be beneficial.


The dashboard is there to show an overview over all bots.

I can see a benefit of it if it can show an overview / summary over multiple bots - but that brings the above mentioned issues.

I'm happy to see solutions to the above mentioned issues - but just showing 1 bot is already solved by switching to the trades pane, and will therefore not be an acceptable PR.

@VanessaE
Copy link
Contributor Author

"solved by switching to the trades pane" -- you missed my point. Zero clicks is better than two clicks. Having more info displayed on one screen is usually better than spreading it across two screens, if laid-out properly.

@xmatthias xmatthias changed the title [FR] Add Balance visualization to Dashboard Add Balance visualization to Dashboard May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Low prio Issues with low priority
Projects
None yet
Development

No branches or pull requests

2 participants