Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display next minimal_roi entry to be reached #448

Open
drakes00 opened this issue Aug 5, 2021 · 1 comment
Open

Display next minimal_roi entry to be reached #448

drakes00 opened this issue Aug 5, 2021 · 1 comment
Labels
enhancement New feature or request Low prio Issues with low priority

Comments

@drakes00
Copy link

drakes00 commented Aug 5, 2021

Is your feature request related to a problem? Please describe.
I'd like to know more easily when a trade is going to be closed due to minimal_roi dict. Currently, all I can do is to check open time and manually compute next potential close date.

Describe the solution you'd like
In trade detail pane, I'd like to have a line showing the next minimal_roi dict entry (it's estimated sell date) and probably put it in red or green depending on if the ROI is reached.

Describe alternatives you've considered

Additional context
I'd be happy to try to do it myself but I don't have much background in vue.
I saw mainly this view to be updated: https://github.com/freqtrade/frequi/blob/master/src/components/ftbot/TradeDetail.vue (alongside trades.ts file) but I guess computations should be done in the main repo (rpc.py file)?

King regards,
Maxime

@xmatthias xmatthias added enhancement New feature or request Low prio Issues with low priority labels Aug 5, 2021
@xmatthias
Copy link
Member

That's correct, you won't be able to handle this in freqUI alone.

I'm also not sure it's straightforward in freqtrade itself - as the ROI method is not meant to be used that way.

I'm however also doubting the sense of having this, as it'll only serve a limited set of strategies.

It might be helpful if you rely on min_roi - but the moment your strategy uses one of the advanced features (custom_sell, custom_stop), trailing stoploss, it'll not really give you much help - as we can't know when custom_sell triggers - as the logic there can be anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Low prio Issues with low priority
Projects
None yet
Development

No branches or pull requests

2 participants