Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiBot -- Bot Addition #564

Open
bibinvargheset opened this issue Nov 1, 2021 · 3 comments
Open

MultiBot -- Bot Addition #564

bibinvargheset opened this issue Nov 1, 2021 · 3 comments
Labels
enhancement New feature or request Low prio Issues with low priority

Comments

@bibinvargheset
Copy link

The bot name is redundant as config file has already a bot name, if those information is added to will reduce confusion and trouble of adding botname. if the bot name is added intially and and can be edited afterwards it would be helpful
Add all multi bots automatically, possibly through wehook to origin or other methods, you can ask for confimation from the user once detected.
Most people use same config in api section for all bots so if multiple bots with same config can be added in one go it would be good

@xmatthias xmatthias added enhancement New feature or request Low prio Issues with low priority labels Nov 1, 2021
@xmatthias
Copy link
Member

automatic addition of bots will not be possible - and if deployed correctly / properly - is also technically not possible as the bot cannot reach the UI (the UI is only running in your browser).

For the rest, feel free to add a Pull request - but please also make sure to not break existing functionality / overwrite botnames the users input.

@xxRockOnxx
Copy link
Contributor

The bot name is redundant as config file has already a bot name, if those information is added to will reduce confusion and trouble of adding botname.

Yea that sounds about right.

  • IP + user + password should be asked
  • fetch the config
  • use the name from the config for the bot's name in the UI

@xmatthias does this sound good?

Add all multi bots automatically, possibly through wehook to origin or other methods, you can ask for confimation from the user once detected.

Although this is doable, it is not possible atm.

New bot servers won't be able to contact your browser to tell your browser there's new server up.

However, your browser can contact a server every now and then to ask if there are new bots added.

How you want will look like:

Bot A -> send ping -> Bot Manager
Bot B -> send ping -> Bot Manager

Browser -> get all bots -> Bot Manager

Implementing a Bot Manager server code = more technical responsibility
For something you can easily done via browser, the effort is just not worth it.

Possibly if Bot Manager can do a lot more than just discovery, the idea can be entertained again.

Most people use same config in api section for all bots so if multiple bots with same config can be added in one go it would be good

So adding multiple addresses with same user/pass you mean? Sounds very convenient but I'm not sure if there's some unwanted implications. @xmatthias might know better.

@xmatthias
Copy link
Member

So adding multiple addresses with same user/pass you mean? Sounds very convenient but I'm not sure if there's some unwanted implications. @xmatthias might know better.

One possibility would be to have a "copy" button for the bot - so you add one manually - and "clone" that - with a different name, and a different address (the address MUST change, as you can't have 2 bots on the same IP:port combination).

The only thing you'd save there would be the username - and potentially the password IF the jwt_secret_key is not different - as we do not store the password directly (and we should not do this, either).

  • use the name from the config for the bot's name in the UI

that's one way if the name is not given for sure - but i'd leave an option to manually rename it (assuming my config has no meaningful bot - or i'd like to "see" it differently in the UI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Low prio Issues with low priority
Projects
None yet
Development

No branches or pull requests

3 participants