Fix #1610 unexpected field-error related to a well-formatted value example of a schema's boolean field using frictionless validate #1615
Conversation
…r to use default true values and default false values
…d 'falseValues' in a schema descriptor
… use default true values and default false values
…d cell: tests pass
…zed trueValues or falseValues properties in schema descriptor
…o validate 'example' value from descriptor boolean field
…with-true-or-false-values-customised
|
Thanks @amelie-rondot! Can you please fix the lining error? |
|
@roll thanks a lot for reviewing! |
…on-boolean-field-with-true-or-false-values-customised
| @@ -263,6 +280,12 @@ def metadata_validate(cls, descriptor: IDescriptor): # type: ignore | |||
| field = Class( | |||
There was a problem hiding this comment.
I think we can just try field = Class.from_descriptor(descriptor) to make it work in general
There was a problem hiding this comment.
It does not work with from_descriptor, it leads to a RecursionError.
frictionless/schema/field.py
Outdated
| if isinstance(descriptor, dict): | ||
| if "trueValues" in descriptor.keys(): | ||
| assert descriptor["type"] == "boolean" | ||
| descriptor["trueValues"] = descriptor["trueValues"] |
There was a problem hiding this comment.
Not sure I understand this block of code =)
BTW as Table Schema is an open spec regarding custom properties we can't disable true/falseValues for other fields
There was a problem hiding this comment.
Indeed, you're right. This block is now useless. I've just committed to remove it.
|
Thanks @roll for reviewing! I've committed updates. |
…on-boolean-field-with-true-or-false-values-customised
|
The change requested have been taken into account and the PR is ready for review ! I noticed some linting errors that seem unrelated to this review, and that I corrected in the other PR (should I have ?). I haven't corrected them in this one as it would mostly lead to merge conflicts. Tell me if you prefer me to do something about it. |
…d-error-on-boolean-field-with-true-or-false-values-customised
`from_descriptor` leads to a `RecursionError`
|
I merged the main branch, this PR is ready as well ! |
This PR fixes the
field-errorwhich occured doingfrictionless validate data.csv --schema schema.jsonwith aTableSchemaschemacontaining aBooleanFieldcustomised with 'trueValues' or 'falseValues' and 'example' value , for example:This PR add tests cases to ensure that example value is correctly evaluated according to customized 'trueValues' or 'falseValues', as expected.