Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure with Python 3.12 but not Python 3.11: no attribute 'delete' #1642

Open
mcarans opened this issue Feb 15, 2024 · 3 comments
Open

Failure with Python 3.12 but not Python 3.11: no attribute 'delete' #1642

mcarans opened this issue Feb 15, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@mcarans
Copy link

mcarans commented Feb 15, 2024

I have found an issue with frictionless with Python 3.12 that doesn't occur with Python 3.11. Here is the trace:

../../../.local/share/hatch/env/virtual/hdx-python-utilities/uS5tbIcO/test.py3.12/lib/python3.12/site-packages/frictionless/formats/excel/parsers/xlsx.py:67: in read_loader
    if not target.delete:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <tempfile._TemporaryFileWrapper object at 0x7ff2d54ab350>
name = 'delete'

    def __getattr__(self, name):
        # Attribute lookups are delegated to the underlying file
        # and cached for non-numeric results
        # (i.e. methods are cached, closed and friends are not)
        file = self.__dict__['file']
>       a = getattr(file, name)
E       AttributeError: '_io.BufferedRandom' object has no attribute 'delete'
@mcarans
Copy link
Author

mcarans commented Feb 20, 2024

@roll Just bringing this issue to your attention as I think it will affect anyone reading Excel with frictionless in Python 3.12.

@mcarans
Copy link
Author

mcarans commented Apr 29, 2024

@roll I tested with frictionless 5.17.0 and unfortunately it doesn't fix this issue

@roll
Copy link
Member

roll commented Apr 30, 2024

Thanks @mcarans!

Yea, I know, I think they found the reason in this thread - Tinche/aiofiles#166

cc @pdelboca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants