Add hidden labels on inputs for SR #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Errec this looks great. It seems that somehow the files from the Here's a link from Stackoverflow that might help you: https://stackoverflow.com/questions/953481/find-and-restore-a-deleted-file-in-a-git-repository |
|
The edits are nice, but you should use already in-place bootstrap’s hide css styles: 📝 https://getbootstrap.com/docs/4.0/utilities/screenreaders/ |
|
Thanks for the suggestions on this. We've made quite a few changes lately in this repo. It would be amazing if you could reopen another PR with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hidden label tags for all inputs using the W3C recommendations to fix #53.