Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faker support for initial development data ? #60

Open
askz opened this issue Jul 5, 2017 · 8 comments
Open

Add faker support for initial development data ? #60

askz opened this issue Jul 5, 2017 · 8 comments

Comments

@askz
Copy link
Contributor

askz commented Jul 5, 2017

(I am actually trying to implement it in my project, will release PR if I succeed and got the time)

@khorolets
Copy link
Collaborator

Don't think it's a good idea for additional external dependency. Also, one can add Faker or Elizabeth with no problem.

@frol
Copy link
Owner

frol commented Jul 5, 2017

Hi @askz, Thank you for the suggestion! I have no time to implement that myself at the moment, but I would love to see a PR for that!

@frol
Copy link
Owner

frol commented Jul 5, 2017

@khorolets We can always make the dependency optional and just skip if the module is missing. However, I have never worked with fakers (I prefer plain Python where things should be simple), so I am not sure if they give any benefit at all.

@khorolets
Copy link
Collaborator

@frol fakers make sense for fixtures for example. I think we can introduce some kind of invoke task to populate some fake data based on factories, but I'm not sure there is a good place for them in initial development data only. If we have task then it's ok to use that factories in initial data IMO.

@frol
Copy link
Owner

frol commented Jul 5, 2017

@khorolets I see.

@askz Please, let us know if you would like to work on a PR, otherwise, we can close this issue since this adds complexity to the example for no good reason.

@askz
Copy link
Contributor Author

askz commented Jul 5, 2017

@khorolets it's a good idea.

@frol I'm working on it !

@Ochirgarid
Copy link

@askz Hello is there any update on this? Asking because I didn't see any on the PR on this issue.
Thank you

@askz
Copy link
Contributor Author

askz commented Jun 24, 2020

Hi unfortunately I stopped working on this project few weeks after writing my issue... so no update sorry !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants