Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing with pg but ok with sqlite #81

Open
askz opened this issue Nov 7, 2017 · 4 comments
Open

Tests failing with pg but ok with sqlite #81

askz opened this issue Nov 7, 2017 · 4 comments

Comments

@askz
Copy link
Contributor

askz commented Nov 7, 2017

Hi, I'm ok with tests since maybe 8 months and I just merged your upstream repo with mine, now I have tests failing with postgres only (which I use in my CI) but with sqlite, no errors. Any ideas ?

https://gist.github.com/askz/33f2d0d8bb6f1d953c7c1ef6f16b4fef

@frol
Copy link
Owner

frol commented Nov 7, 2017

I have no idea what caused the change of client_id from regular_user_client to OAUTH2_regular_user in the first two failing tests.

As to the last two, I expected that, PostgreSQL uses auto incrementing which never gets reset (even if you delete all the records from a table), which is why /1 and /2 IDs return 404, since there were other tests before this one, which took those IDs earlier and already dropped the records. We should implement a more robust tests instead implicitly hoping that those IDs will match in runtime.

@askz
Copy link
Contributor Author

askz commented Nov 7, 2017

Okay, I'll try to fix that by referecing instances directly.

@frol
Copy link
Owner

frol commented Dec 19, 2017

@askz Have you had a chance to fix that?

@askz
Copy link
Contributor Author

askz commented Dec 20, 2017

Not at all, sorry... In fact I leaved the project where I was using your base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants