Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub pages #1

Open
felixfbecker opened this issue Oct 21, 2018 · 4 comments
Open

Enable GitHub pages #1

felixfbecker opened this issue Oct 21, 2018 · 4 comments

Comments

@felixfbecker
Copy link

This cheatsheet is great. If GitHub pages were enabled, one could directly view it in the browser in an accessible way (as opposed to the image which doesn't work with a screen reader).

@jamesknelson
Copy link
Contributor

I do want to set this up so it's viewable on frontarm.com as HTML instead of an image, but it'll take a little work as the layout is currently hacked together to target "print as pdf" in Chrome.

Regarding accessibility, I think the current markup would need some work too, as the promises are just spans with a CSS class, so they'd be read as "value" instead of "promise to value". That could probably be fixed without my help, and I'd be glad to merge it in.

@felixfbecker
Copy link
Author

I think it would be great even if it targets Print to PDF currently (would make it easy to do so without having to clone the repo) :)

@felixfbecker
Copy link
Author

Probably also want to reference the Lato font as a webfont

@jamesknelson
Copy link
Contributor

Referencing the Lato font makes sense. Will also need to add Fira Code. Unfortunately its not available on google web fonts so it'll take a little work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants