Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Google Ad Manager AMP aware #822

Draft
wants to merge 14 commits into
base: dev
Choose a base branch
from
Draft

Make Google Ad Manager AMP aware #822

wants to merge 14 commits into from

Conversation

DAreRodz
Copy link
Member

@DAreRodz DAreRodz commented May 18, 2021 •
edited

What:

Render an <amp-ad> tag for each slot configured in settings.

Why:

To close #714

How:

Creating an AmpAd component that would be rendered if frontity.mode is amp.

Tasks:

  • Code
  • TSDocs
  • TypeScript
  • Unit tests
  • End to end tests
  • TypeScript tests
  • Update starter themes
  • Update other packages
  • Update community discussions
  • Add a changeset (with link to its Feature Discussion if it exists)

Unrelated Tasks

Additional Comments

@DAreRodz DAreRodz self-assigned this May 18, 2021
@changeset-bot
Copy link

changeset-bot bot commented May 18, 2021 •
edited

⚠️ No Changeset found

Latest commit: d95da23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@github-actions
Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DAreRodz DAreRodz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make @frontity/google-ad-manager AMP-aware [8pt]
1 participant
@DAreRodz