-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Equipment confirmation modal for equipping arti/weapons #2054
Comments
Here is another thought, can be combine the "Confirm Equipment" Modal with the "build diff" modal? they share a lot of the same UI elements, it is not a stretch to combine them. Would require breaking up |
Probably a good idea to standardize the build swap confirmation for consistency's sake as well. I dunno how often users accidentally equip an artifact/weapon or equip to the wrong build whether by directly clicking on it or misclicking in the dropdown, but in theory, this would guard against that too. That being said, I can see some potential value in merging |
When swapping artifact/weapons, you are presented with this screen:
Clicking on the green will pop up a comparison, and then upon equip, will show this screen: whereas clicking on the Red will swap without popping up the build confirmation screen.Since this build confirmation screen is very useful, we should standardize it, and apply it to both equipment path.
Question: does this make sense to also apply this to the equipment dropdown in artifactcard/weaponcard as well?
The text was updated successfully, but these errors were encountered: