Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert/Disclaimer on character editor UI #2085

Open
frzyc opened this issue May 9, 2024 · 2 comments
Open

Alert/Disclaimer on character editor UI #2085

frzyc opened this issue May 9, 2024 · 2 comments
Labels
good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR

Comments

@frzyc
Copy link
Owner

frzyc commented May 9, 2024

Users can still swap artifacts using the character UI, as well as compare, however, the comparison here is a "character-only" calculation with some caveats:
image

Add an alert to indicate to the user that this screen has:

  • Default enemy stats
  • no multi-targets
  • No talent conditionals or bonus stats or anything that gives a character nuance
  • If people wants to see more contextual numbers with all of the above, they should put the character in a team.
@frzyc frzyc added the good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR label May 9, 2024
@artloren
Copy link
Contributor

I can take a look. Is there a set of text and translations that you want to see in the alert?

@nguyentvan7
Copy link
Collaborator

These numbers are calculated without any additional context. Team buffs, bonus stats, conditionals, multi-opts and custom enemy stats are not factored in. To see these additional details, view this information in the context of a specific team + loadout.

Or something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR
Projects
None yet
Development

No branches or pull requests

3 participants