Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add db import info for team/loadout/build #2145

Closed
frzyc opened this issue May 17, 2024 · 14 comments · Fixed by #2174
Closed

Add db import info for team/loadout/build #2145

frzyc opened this issue May 17, 2024 · 14 comments · Fixed by #2174

Comments

@frzyc
Copy link
Owner

frzyc commented May 17, 2024

image
Currently only shows art/weapon/char

For importing GO data on another GO data for team/loadout, I believe the current logic is the import data overwrite the existing data. I think I am fine with that, deduping would be unnecessarily complicated, the UI should just reflect this.

@CordonZeus22
Copy link
Contributor

I will work on it

@CordonZeus22
Copy link
Contributor

Actually, importing teams doesn't remove existing teams not in import. Even with the Delete items not in import option. Same for loadout. Is this behavior intended ?

@nguyentvan7
Copy link
Collaborator

Seems so https://discord.com/channels/785153694478893126/1218906581593231540, tho i still feel like its weird that teams are not deleted with that setting enabled

@CordonZeus22
Copy link
Contributor

This thread has been marked as not a bug. So, this behavior shouldn't be changed ?

@nguyentvan7
Copy link
Collaborator

Leaving @frzyc to give final say

@frzyc
Copy link
Owner Author

frzyc commented May 18, 2024

For importing GO data on another GO data for team/loadout, I believe the current logic is the import data overwrite the existing data. I think I am fine with that, deduping would be unnecessarily complicated, the UI should just reflect this.

Yeah i do not think its worth any developer's time to dedup/merge team/loadouts. The ask for this issue is basically just add a tally as a visual for users, and not to add any complex logic to db

@CordonZeus22
Copy link
Contributor

There is already a dedup/merge for team and loadouts I think

@CordonZeus22
Copy link
Contributor

If no dedup/merge should be done, what will be written on the card ?

@frzyc
Copy link
Owner Author

frzyc commented May 21, 2024

Just the number of team/loadout/builds before import, and after

@CordonZeus22
Copy link
Contributor

Also TC Builds ?

@frzyc
Copy link
Owner Author

frzyc commented May 21, 2024

Yes, and TC builds

@CordonZeus22
Copy link
Contributor

How the total amout of loadouts can be computed ?

@frzyc
Copy link
Owner Author

frzyc commented May 23, 2024

yeah loadouts are called teamChars(due to legacy naming) so it would be database.teamChars.values.length

@CordonZeus22
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants