Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -10 and -30 values to resin counter #2151

Merged
merged 2 commits into from
May 20, 2024
Merged

Add -10 and -30 values to resin counter #2151

merged 2 commits into from
May 20, 2024

Conversation

josh-the-dev
Copy link
Contributor

@josh-the-dev josh-the-dev commented May 19, 2024 •
edited by frzyc

Describe your changes

Added more options to the resin counter. Moved the buttons to a constant at the top to allow for more values later down the line easily.

Issue or discord link

Testing/validation

image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@josh-the-dev
Copy link
Contributor Author

Will go through the checklist in a moment.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 19, 2024 •
edited

[frontend] [Sun May 19 10:36:59 UTC 2024] - Deployed 7ba8be1 to https://genshin-optimizer-prs.github.io/pr/2151/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun May 19 11:11:47 UTC 2024] - Deployed 393889f to https://genshin-optimizer-prs.github.io/pr/2151/frontend (Takes 3-5 minutes after this completes to be available)

[Sun May 19 16:52:44 UTC 2024] - Deleted deployment

[frontend] [Mon May 20 03:35:20 UTC 2024] - Deployed eebb7b7 to https://genshin-optimizer-prs.github.io/pr/2151/frontend (Takes 3-5 minutes after this completes to be available)

[Mon May 20 04:01:14 UTC 2024] - Deleted deployment

@josh-the-dev
Copy link
Contributor Author

I've added a new commit which should also address : #2150

Evidence here:
image

frzyc
frzyc approved these changes May 19, 2024
View reviewed changes
Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@josh-the-dev josh-the-dev reopened this May 19, 2024
@josh-the-dev
Copy link
Contributor Author

Woops didn't mean to close 😅 . What are next steps to getting this merged? @frzyc you just handle that I assume ha!

@frzyc frzyc merged commit 36b613d into frzyc:master May 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frzyc frzyc frzyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resin counter cutoff when >999 resin Add a -30 to the resin counter
2 participants
@josh-the-dev @frzyc