-
-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panic in v1.7.0 #616
Comments
I can't do anything with this; you'll need to either give more details on how to reproduce or track down the problem yourself. |
I apologise but we are not able to repro this at all. And there's no specific application state that caused this to occur. |
I mean, there's no details here at all; not even how or where you're using it, or what kind of events are happening, or ... anything. The panic is triggered on IN_DELETE_SELF: the watched path was deleted. This is handled (and tested), but it seems some specific sequence of events cause this error for some reason, but I'm not going to spend ages trying random stuff to find out what. Any clue on usage patterns would be useful. Or if you want to know exactly, use |
I have the same panic happening time to time on my micro-services. The library is used indirectly by viper
The file using fsnotify : https://github.com/spf13/viper/blob/master/viper.go The problem is strange because it appears on a daemon that doesn't use viper at all, so I'm guessing something that would happen in an init. I'll give you more details if I find anything. |
I added FSNOTIFY_DEBUG in #619. |
I just stumbled upon the same issue, and it reproduces consistently running one of the Cilium's unit tests a few times:
Output updating fsnotify to 77d5fee and running with
Feel free to let me know if you need more information for troubleshooting it. |
Thanks; I can reproduce it with that fairly reliably. Reducing that to a test case seems a bit non-trivial, as it's pretty complex. I think what's going on that it that it manually calls Watcher.Remove() for paths that are deleted, and events arrive for that path after it's removed from the internal book-keeping. Or something along those lines – my test cases for this always work, but maybe I need to add more goroutines or something for more racy-ness. |
Here's a basic test case:
|
Describe the bug
Panic occured randomly in one of our microservices.
Code to Reproduce
Not able to reproduce
File operations to reproduce
NA
Which operating system and version are you using?
Linux 6.1.58+ SMP PREEMPT_DYNAMIC Mon Jan 29 15:19:25 UTC 2024 x86_64 Linux
Which fsnotify version are you using?
v1.7.0
Did you try the latest main branch?
No
The text was updated successfully, but these errors were encountered: