Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Frontend #63

Closed
Clashsoft opened this issue Jan 30, 2020 · 1 comment
Closed

Angular Frontend #63

Clashsoft opened this issue Jan 30, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Clashsoft
Copy link
Member

Clashsoft commented Jan 30, 2020

This is being worked on in the angular branch.

@Clashsoft Clashsoft added enhancement New feature or request post-thesis labels Jan 30, 2020
@Clashsoft
Copy link
Member Author

Clashsoft commented Feb 6, 2020

Current differences to the vanilla implementation:

  • form elements turn white when focused. Seems to be a specificity issue between [data-theme=dark] .form-control vs .form-control:focus.
  • the "Compile and Run" button has no tooltip.
  • using the keyboard shortcuts in the scenario editor to submit does not show the Loading... labels. This was because the keyboard event handlers ran submit outside of the Angular zone so change detection did not work.
  • there is no space between "Load Example:" and the dropdown
  • sometimes all object diagram tabs are deselected. This was because of Can't use 0 as nav id ng-bootstrap/ng-bootstrap#3569. Now the tabs use 1-based indexing.

Differences that are acceptable:

  • Download Gradle project does not save the configuration (but DOES use the configuration values from the inputs). This is intentional because it doesn't close the modal; we want the user to click "Save".
  • Closing and then reopening the configuration modal without saving retains the unsaved changes. This is considered a bug in the vanilla implementation.

@Clashsoft Clashsoft self-assigned this Feb 7, 2020
@Clashsoft Clashsoft added this to the v1.1.0 milestone Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant