Use HTTPS url for vue 3 submodule #6714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Queued for release The v6 version of the codebase has the git submodule root at this repo now: I'm actually using relative URLs now, so if you clone the fullcalendar-workspace repo with https, all submodules will be cloned with https as well |
|
Released in v6.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I got stopped by a "permission denied (publickey)" error when following the setup instructions in CONTRIBUTING.md, and found that the cause was an SSH url used by the Vue 3 submodule. I'm guessing this was an oversight since the other submodules all use HTTPS. With this change, it's possible to clone the repository anonymously.