Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-day event is partially visible when hidden by dayMaxEvents with eventOrderStrict #7002

Open
kaiwenlau opened this issue Oct 17, 2022 · 4 comments

Comments

@kaiwenlau
Copy link

kaiwenlau commented Oct 17, 2022

Reduced Test Case

https://codepen.io/kaiwenlau/pen/YzLMWKq

Bug Description

eventOrder is default order.
eventOrderStrict set to true.
dayMaxEvents set to 2 on DayGrid, while dayMaxEvents set false on TimeGrid.
The PB event is a multi-day allDay event, range from 19th October to 21st October.

Outcome:

  • TimeGrid shows the PB event under MA event, this is correct, as the start is after MA event.
  • DayGrid shows the PB event differently, on 19th it is hided in more link because the dayMaxEvent set to 2
  • While on 20th it shows half of the event.

Expected result:

  • PB event is a multi-day event should either show all or hide all, but not show in half.
  • PB event should hide in more link if part of it is unable to display.
  • My expected result is attached as the 3rd screenshots.

Screenshots

image
image

Expected Result:
image

@kaiwenlau kaiwenlau changed the title Multi-day event is cut in half and did not follow eventOrderStrict Multi-day event is cut in half in eventOrderStrict Oct 17, 2022
@acerix acerix changed the title Multi-day event is cut in half in eventOrderStrict Multi-day event is partially visible when hidden by dayMaxEvents with eventOrderStrict Nov 7, 2022
@arshaw
Copy link
Member

arshaw commented Dec 5, 2022

@kaiwenlau , thanks for this thorough bug report. I can see there's a bug.

@dunz
Copy link

dunz commented May 30, 2023

I am currently using version 6.1.8 and still experiencing this issue. When can we expect a fix for this problem?

@arshaw
Copy link
Member

arshaw commented Feb 20, 2024

Updated repro with v6.1.11 (still not fixed):
https://codepen.io/arshaw/pen/ZEPZRbK?editors=0010

The bug is less severe than I originally thought. The calendar is trying its best to display 2 events max per day while maintaining strict order. I supposed we could tweak the behavior to prevent events whose start-dates are not displayed from showing. Though I bet some people might actually want this behavior in some cases. We could potentially introduce a flag to to prevent against this behavior.

@cttboehme
Copy link

We are having the exact some problem (parts of a multi-day event are disappearing) even without strict ordering. At first we thought this happens on particularly full days, but it is happening even on moderately full days, e.g. 1 or 2 other events. Since this affects the reliability of the calendar, we are eagerly looking for a fix or workaround. 🥺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants