Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose globalLocales publicly for importing on-demand #7057

Closed
boris-petrov opened this issue Dec 14, 2022 · 1 comment
Closed

Expose globalLocales publicly for importing on-demand #7057

boris-petrov opened this issue Dec 14, 2022 · 1 comment
Labels
Discussing Distribution i18n
Milestone
v6.0.1

Comments

@boris-petrov
Copy link

Reduced Test Case

not reproducible with a link

Bug Description

I updated the package to version 6 and in the documentation it says to open an issue if I believe something should be exposed.

In my case, I want to import locales on-demand and at runtime. Which means I expose the .global.min.js files and load them dynamically. Internally in them they use FullCalendar.Internal.globalLocales. So that must be made public.

I also pass the globalLocales as locales of CalendarOptions. And I also use globalLocales to check which locales have been loaded already.

Just to name you a few use-cases of globalLocales and why I think it must be made public.
@acerix acerix changed the title [6.0.0] globalLocales should be public Expose globalLocales publicly for importing on-demand Dec 14, 2022
@arshaw arshaw added this to the v6-upcoming milestone Dec 16, 2022
@arshaw arshaw closed this as completed in 229b88d Dec 20, 2022
@arshaw
Copy link
Member

arshaw commented Dec 20, 2022

Released in v6.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussing Distribution i18n
Projects
None yet
Milestone
v6.0.1
Development

No branches or pull requests
3 participants
@arshaw @boris-petrov @acerix