Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum update depth exceeded when using eventContent and dayMaxEvents with events extending to the next day #7116

Closed
1 task done
ethan-heo opened this issue Dec 30, 2022 · 5 comments

Comments

@ethan-heo
Copy link

ethan-heo commented Dec 30, 2022

Reduced Test Case

https://codesandbox.io/s/fullcalendar-issue-rfj5vl

Do you understand that if a reduced test case is not provided, we will intentionally delay triaging of your ticket?

  • I understand

Which connector are you using (React/Angular/etc)?

React

Bug Description

A problem occurs when you use eventContent and dayMaxEvents together and the event data contains data whose end date exceeds the next day relative to the start date.

The mock data was created as of December 2022, so please check the calendar for December last year.

@acerix acerix changed the title The problem occurs when the end date goes beyond the next day Maximum update depth exceeded when using eventContent and dayMaxEvents with events extending to the next day Jan 3, 2023
@acerix
Copy link
Member

acerix commented Jan 3, 2023

Thanks confirmed. As a workaround, it seems to work by changing eventOrder so the events are not sorted by start time:

https://codesandbox.io/s/fullcalendar-issue-forked-5g9qlg?file=/src/App.tsx

@ethan-heo
Copy link
Author

Thank you for answer. But this doesn't seem to be a fundamental solution. This solution is tied to development requirements and is difficult to change. 😥

@arshaw arshaw added this to the v5-upcoming milestone Jan 9, 2023
@arshaw
Copy link
Member

arshaw commented Jan 9, 2023

confirmed. this is a regression (it worked in v5)

@arshaw
Copy link
Member

arshaw commented Jan 9, 2023

queued for release fullcalendar/fullcalendar-workspace@a667945

@arshaw arshaw closed this as completed Jan 9, 2023
@arshaw
Copy link
Member

arshaw commented Jan 11, 2023

Released in v6.0.3

Updated repro:
https://codesandbox.io/s/fullcalendar-issue-forked-gcvtbn?file=/src/App.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants