Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moreLinkContent is not updated with current state #7119

Closed
1 task done
Mohamedsobhy292 opened this issue Jan 3, 2023 · 3 comments
Closed
1 task done

moreLinkContent is not updated with current state #7119

Mohamedsobhy292 opened this issue Jan 3, 2023 · 3 comments

Comments

@Mohamedsobhy292
Copy link

Reduced Test Case

https://codesandbox.io/s/vigorous-frog-osk7hq?file=/src/App.js

Do you understand that if a reduced test case is not provided, we will intentionally delay triaging of your ticket?

  • I understand

Which connector are you using (React/Angular/etc)?

React

Bug Description

  • after upgrading to version 6.2 the custom more link component is not rendering when there's a prop passed it from the calendar component have changed

steps to reproduce

  • open the codesandbox link
  • click on the increase count button
  • the count passed to the component still the same
@acerix acerix changed the title More link from moreLinkContent does not render when props changes moreLinkContent is not updated with current state Jan 3, 2023
@acerix
Copy link
Member

acerix commented Jan 3, 2023

It seems the link is re-rendered, but for some reason it gets the initial count instead of the current state.

https://codesandbox.io/s/strange-almeida-s3spiw?file=/src/App.js

Since that works, you could store a copy of the value as a global and use that as a workaround.

@arshaw arshaw added this to the v5-upcoming milestone Jan 9, 2023
@arshaw
Copy link
Member

arshaw commented Jan 9, 2023

queued for release fullcalendar/fullcalendar-react@e822df6...28652f4

@arshaw arshaw closed this as completed Jan 9, 2023
@arshaw
Copy link
Member

arshaw commented Jan 11, 2023

Released in v6.0.3

Updated repro: https://codesandbox.io/s/crazy-tree-sulosc?file=/src/App.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants