Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventContent rendered loop after event drop on React <18 #7127

Closed
1 task done
Arithmetics opened this issue Jan 6, 2023 · 2 comments
Closed
1 task done

eventContent rendered loop after event drop on React <18 #7127

Arithmetics opened this issue Jan 6, 2023 · 2 comments

Comments

@Arithmetics
Copy link

Arithmetics commented Jan 6, 2023

Reduced Test Case

https://codesandbox.io/s/fullcalendar-issue-forked-xfuus9?file=/src/App.tsx

Do you understand that if a reduced test case is not provided, we will intentionally delay triaging of your ticket?

  • I understand

Which connector are you using (React/Angular/etc)?

React connector

Bug Description

When providing eventContent to the react <FullCalendar /> component, the function will be called many times over during event editing, crashing the calendar if the application is using a sub 18 version of react (ex. react 17 or react 16).

To reproduce:

  1. open test case
  2. open console
  3. drag and drop an event
  4. observed 10,000's of console logs and event calendar rendering bugs

This behavior is not present on react 18 applications.

Screen.Recording.2023-01-06.at.3.01.07.PM.mov
@acerix acerix changed the title eventContent rendered recursively when on <18 React versions eventContent rendered loop after event drop on React <18 Jan 7, 2023
@arshaw arshaw added this to the v5-upcoming milestone Jan 9, 2023
@arshaw
Copy link
Member

arshaw commented Jan 11, 2023

queue for release fullcalendar/fullcalendar-react@4e439dd

@arshaw arshaw closed this as completed Jan 11, 2023
@arshaw
Copy link
Member

arshaw commented Jan 11, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants