Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dot-event element from eventDidMount does not exists in the DOM in dayGridMonth view for Vue2/Angular #7191

Closed
1 task done
Yaty opened this issue Feb 2, 2023 · 10 comments

Comments

@Yaty
Copy link

Yaty commented Feb 2, 2023

Reduced Test Case

https://stackblitz.com/edit/github-anq735?file=src/DemoApp.vue

Do you understand that if a reduced test case is not provided, we will intentionally delay triaging of your ticket?

  • I understand

Which connector are you using (React/Angular/etc)?

Vue

Bug Description

Hello,

I'm using full-calendar 6.1.1 (and 6.1.2 for the vue connector).

I found out that when I'm on the dayGridMonth view, the fc-daygrid-dot-event elements passed inside the eventDidMount hook does not exists in the DOM, this prevents me from attaching a tooltip on it.

There are no problems with fc-daygrid-block-event. I don't have the issue on 6.0.2.

Thanks!

@stefanomiccoli
Copy link

I have the same issue with angular.

@arshaw arshaw added this to the upcoming-release milestone Feb 6, 2023
@arshaw arshaw changed the title dot-event element from eventDidMount does not exists in the DOM in dayGridMonth view dot-event element from eventDidMount does not exists in the DOM in dayGridMonth view for Vue2/Angular Feb 7, 2023
@arshaw
Copy link
Member

arshaw commented Feb 7, 2023

Not fixed in v6.1.3 (updated repro)

Moving to next bugfix milestone

@Alex-Doro
Copy link

Similar issue on Angular, had to roll back to v5.
Full-calendar seems to have the full list of events that need to rendered, however, after any re-render customRenderingArray and customRenderingMap seem to contain way less events. Seems like any event that has a similar start time with other events is cut off and only one of them actually gets rendered

@arshaw
Copy link
Member

arshaw commented Mar 21, 2023

@arshaw
Copy link
Member

arshaw commented Mar 21, 2023

Version v6.1.5 (just released) fixed this bug and you can see proof in the above modified reproduction.

Please post here if any further issues about this.

@arshaw arshaw closed this as completed Mar 21, 2023
@Yaty
Copy link
Author

Yaty commented Mar 22, 2023

Hi @arshaw, thanks for the update, unfortunately I think the issue still remains. I'm using your reproduction.

For block events it's working properly as before, when I select the node that is printed in the console my browser can correctly find it :
image

However for dot events it seems the element passed through eventDidMount is no where on the document, i.e if I select the node printed in the console, it does not exists/the browser cannot find it :
image

So this prevents me from manipulating the element (attaching a tooltip in my case).
I use Firefox 111.

@Alex-Doro
Copy link

The problem in Angular with customRenderingArray and customRenderingMap cutting off events persists for me as well

@arshaw
Copy link
Member

arshaw commented Apr 3, 2023

I'll reinvestigate for the next bugfix release

@arshaw arshaw reopened this Apr 3, 2023
@arshaw arshaw modified the milestones: v6.1.5, next-release Apr 3, 2023
@arshaw
Copy link
Member

arshaw commented Sep 21, 2023

This is fixed "for real" in v6.1.9

Could anyone from this thread verify please?

@arshaw arshaw closed this as completed Sep 21, 2023
@arshaw arshaw modified the milestones: next-release, v6.1.9 Sep 21, 2023
@Yaty
Copy link
Author

Yaty commented Sep 22, 2023

looks good on my side, thanks @arshaw !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

5 participants