Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar does not correctly limit events to fit in the cell after changing date with React strict mode #7400

Closed
1 task done
gfrn opened this issue Jul 13, 2023 · 1 comment

Comments

@gfrn
Copy link

gfrn commented Jul 13, 2023

Reduced Test Case

https://codepen.io/gfrn/pen/poQaJow

Do you understand that if a reduced test case is not provided, we will intentionally delay triaging of your ticket?

  • I understand

Which connector are you using (React/Angular/etc)?

React

Bug Description

Reproduction:

  1. Confirm you have React strict mode enabled
  2. Go back a month (in this case, to June, from July)
  3. Confirm list of custom event content items overflows beyond the day's box (all items are displayed regardless of the size of the actual container)
  4. Resizing the page once fixes this behaviour

image

Expected behaviour:

Day grid box should not display all items if they do not fit; a "more events" button should be displayed instead

image

Description

Enabling strict mode breaks rendering custom content, as they are no longer taken into consideration for determining whether or not the number of displayed items should be limited. Instead, all items are displayed, and they overflow beyond the boundaries of calendar dates.

This does not occur outside strict mode.

@acerix acerix changed the title React strict mode causes calendar events to overflow beyond date container boundaries Claendar does not resize to fit events after changing date with React strict mode Jul 21, 2023
@acerix acerix changed the title Claendar does not resize to fit events after changing date with React strict mode Calendar does not correctly limit events to fit in the cell after changing date with React strict mode Jul 21, 2023
@arshaw
Copy link
Member

arshaw commented Feb 20, 2024

Fixed in v6.1.11

@fullcalendar/react was getting tripped up on React strict-mode.

Updated repro:
https://codepen.io/arshaw/pen/LYavmom?editors=1010

@arshaw arshaw closed this as completed Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants