Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table selection is not prevented when long pressing to drag events in Safari #7441

Closed
1 task done
Wolfram-Zell opened this issue Aug 29, 2023 · 5 comments
Closed
1 task done
Assignees
Milestone

Comments

@Wolfram-Zell
Copy link

Wolfram-Zell commented Aug 29, 2023

Reduced Test Case

https://fullcalendar.io/demos

Do you understand that if a reduced test case is not provided, we will intentionally delay triaging of your ticket?

  • I understand

Which connector are you using (React/Angular/etc)?

React

Bug Description

If the calendar is touched/clicked body gets "user-select: none", this does not work on Safari and Safari for iOS.
One solution is to add

el.style.webkitUserSelect = 'none'

to function preventSelection(el: HTMLElement) in /packages/core/src/util/misc.ts

@acerix
Copy link
Member

acerix commented Sep 4, 2023

I'm not sure what the issue is, what is the expected/actual behaviour when selecting an event (as visible to the user)?

@Wolfram-Zell
Copy link
Author

On iOS the table will be selected on longer tap, on any Android/LInux/Windows device this is not the case, because while a mouse button is pressed, or the screen is touched body gets user-select: none. Safari on iOS and MacOS does not support user-select and needs the prefix. See Can I use: https://caniuse.com/?search=user-select

@acerix acerix changed the title user-select needs -webkit- prefix to work on Safari Table selection is not prevented owhen long pressing events in Safari Sep 5, 2023
@acerix acerix changed the title Table selection is not prevented owhen long pressing events in Safari Table selection is not prevented when long pressing to drag events in Safari Sep 5, 2023
@SlavaGeorgiev
Copy link
Contributor

@acerix please see #7442 as PR which fixes the issue.

@arshaw arshaw added this to the next-release milestone Sep 19, 2023
@arshaw
Copy link
Member

arshaw commented Sep 21, 2023

Merged and fixed in v6.1.9. Thanks for the PR! Can you please verify?

@arshaw arshaw modified the milestones: next-release, v6.1.9 Sep 21, 2023
@arshaw arshaw closed this as completed Sep 21, 2023
@SlavaGeorgiev
Copy link
Contributor

Sure will do, planing a task for next sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants