Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use universal methods to manipulate the HTML element #32

Open
fulls1z3 opened this issue Apr 4, 2017 · 3 comments
Open

use universal methods to manipulate the HTML element #32

fulls1z3 opened this issue Apr 4, 2017 · 3 comments

Comments

@fulls1z3
Copy link
Owner

fulls1z3 commented Apr 4, 2017

I'm submitting a ... (check one with "x")

[ ] bug report => check the README and search github for a similar issue or PR before submitting
[ ] support request => check the README and search github for a similar issue or PR before submitting
[X] feature request

Current behavior
In @nglibs/meta v0.2.0-rc.5, manipulating the HTML element (to set the lang attribute) has been commented out, in scope of preventing direct DOM manipulation.

Expected/desired behavior
We need to set the lang attribute of HTML element, using universal methods as they become available.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Angular version: 2.0.X
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version =

@samvloeberghs
Copy link

They did miss that one.. I'm setting it after rendering the HTML for now

@fulls1z3
Copy link
Owner Author

fulls1z3 commented Apr 8, 2017

I think I know why they missed that one. It is simply not within the scope of title.service and meta.service.

On the other hand, I could develop a method to do it by using the DomAdapter, but as of version 4, we can not access to DomAdapter outside Angular.

Seems like I'll need to develop and integrate it into Angular and make a PR. With the next release of Angular, the v0.4.x can use it (by enforcing that Angular version in peerDependencies) while the v0.2.x can do it internally (accessing the DomAdapter).

@fulls1z3 fulls1z3 added this to the v0.2.0-rc.6 milestone Apr 12, 2017
@fulls1z3
Copy link
Owner Author

fulls1z3 commented May 9, 2017

@fulls1z3 fulls1z3 modified the milestones: v0.2.0, v0.2.0-rc.6 May 9, 2017
@fulls1z3 fulls1z3 added the v0.4.x label Sep 3, 2017
@fulls1z3 fulls1z3 modified the milestones: v0.4.0, v0.2.0 Sep 3, 2017
@fulls1z3 fulls1z3 modified the milestones: v4.1.0, v4.0.0 Sep 6, 2017
@fulls1z3 fulls1z3 changed the title [enhancement] use universal methods to manipulate the HTML element use universal methods to manipulate the HTML element Sep 16, 2017
@fulls1z3 fulls1z3 added v5 and removed v4 labels Jan 7, 2018
@fulls1z3 fulls1z3 added v6 and removed v5 labels Apr 16, 2018
@fulls1z3 fulls1z3 removed this from the v6.1.0 milestone Jul 23, 2018
@fulls1z3 fulls1z3 assigned samvloeberghs and unassigned fulls1z3 Nov 22, 2019
@fulls1z3 fulls1z3 removed the v6 label Nov 22, 2019
@samvloeberghs samvloeberghs removed their assignment Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants