Merge pull request #259 from vktrl/master

fix undefined check, add null test for browser
fullstack-build · Aug 23, 2023 · 3044fce · 3044fce
2 parents c24f7e1 + be1e549
commit 3044fce
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/src/runtime/browser/util.inspect.polyfil.ts b/src/runtime/browser/util.inspect.polyfil.ts
@@ -63,7 +63,7 @@ function isBoolean(arg: unknown) {
 }
 
 function isUndefined(arg: unknown) {
-  return arg == null;
+  return arg === undefined;
 }
 
 function stylizeNoColor(str: string) {

diff --git a/tests/Browser/1_json.test.ts b/tests/Browser/1_json.test.ts
@@ -75,4 +75,14 @@ describe("Browser: JSON: Log level", () => {
 
     expect(consoleOutput).toContain("Foo bar");
   });
+
+  it("pretty nullish", async () => {
+    await page.evaluate(() => {
+      // @ts-ignore
+      const logger = new tslog.Logger({ type: "pretty", stylePrettyLogs: false });
+      logger.info({ foo: null, bar: undefined });
+    });
+    expect(consoleOutput).toContain("null");
+    expect(consoleOutput).toContain("undefined");
+  });
 });
diff --git a/tests/Nodejs/5_pretty_Log_Types.test.ts b/tests/Nodejs/5_pretty_Log_Types.test.ts
@@ -45,6 +45,12 @@ describe("Pretty: Log Types", () => {
     expect(getConsoleLog()).toContain("555");
   });
 
+  test("null", (): void => {
+    const logger = new Logger({ type: "pretty" });
+    logger.log(1234, "testLevel", null);
+    expect(getConsoleLog()).toContain("null");
+  });
+
   test("Array, stylePrettyLogs: false", (): void => {
     const logger = new Logger({ type: "pretty", stylePrettyLogs: false });
     logger.log(1234, "testLevel", [1, 2, 3, "test"]);