New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoset-out does not get namespace when using reflection #464
Comments
What server implementation is returning that from the reflection endpoint? This seems like a clear bug in the reflection endpoint. If the type references are not qualified, they are not valid. |
We're using nestjs. But the grpcui is getting the correct namespace on the same server using reflection only. So I don't think it's in the server. But I might be wrong |
This seems rather hard to understand since grpcui uses grpcurl as a library, and uses the exact same code to load/process the schemas. What version of grpcurl and what version of grpcui? |
After spending most of my day yesterday debugging and diving down into the code of various libraries. The issues seems to be with how protobufjs generates the binaries vs how protoc does. From my understanding of grpcurl and grpcui, and please correct me if I'm wrong: When using |
Closing because I don't think this is caused by grpcurl |
Using -protoset-out to generate descriptors does not seem to keep namespaces for types when using reflection.
When comparing the descriptors using
protoc --decode_raw
for the same service using either the.proto
file or reflection the field looks as followsUsing reflection on the same server using https://github.com/fullstorydev/grpcui it sees that the namespace is definitely available for reflection:
Generating grpc clients fails if the namespace is not available, for a lot of reasons using the
.proto
file directly is not easily achievable, so getting the full type to the descriptors is highly preferableThe text was updated successfully, but these errors were encountered: