Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call resolve-key in sign function on pkey #93

Open
janetacarr opened this issue Apr 18, 2024 · 0 comments
Open

Call resolve-key in sign function on pkey #93

janetacarr opened this issue Apr 18, 2024 · 0 comments

Comments

@janetacarr
Copy link

Hey Buddy!

I'm not sure if this entirely qualifies as an issue, so close it if not, but I just discovered that you can sign tokens with nil as the pkey/secret, but not unsign the same token with nil as there's no implementation of IKeyProvider (used by unsign ala resolve-key here )

So, should there be a call to resolve-key in the sign function? found here

Anyways, let me know if this was intended or not. If not, I'll open a PR.

@janetacarr janetacarr changed the title Add resolve-key to sign function on pkey Call resolve-key in sign function on pkey Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant