Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print errors outside of debug mode #41

Open
pixelherodev opened this issue Aug 4, 2019 · 1 comment
Open

Print errors outside of debug mode #41

pixelherodev opened this issue Aug 4, 2019 · 1 comment
Labels

Comments

@pixelherodev
Copy link
Contributor

As far as I can tell, zero info is printed if CR_DEBUG isn't defined, not even errors. I personally don't think the define should have to be added to get basic info like "Couldn't load plugin: ./libSIMPLE-Sokol1.so: undefined symbol: get_delta".

If you disagree, feel free to close this issue, this is just a personal opinion.

I am more than willing to make the changes myself and submit a PR, but I'd rather get your input on whether it's a change you'd accept anyways before putting in that work.

@fungos
Copy link
Owner

fungos commented Aug 12, 2019

CR_ERROR can be a different toggle than CR_DEBUG, I'm ok changing this. But let keep a define to it as not everyone is happy including stdio.h/printf and I do not want any more public API changes (eg. to register a print function)

@fungos fungos added the waiting label Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants