Refactor Main.java #161
Closed
Refactor Main.java #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Does anyone know why the sonarCloud thinks there is a bug when I only refactored the code? |
RobertMili
approved these changes
Feb 20, 2023
kappsegla
requested changes
Jan 31, 2024
fshould fix the old pull request denial on refactor main
kappsegla
reviewed
Feb 1, 2024
pom.xml
Outdated
| @@ -8,7 +8,7 @@ | |||
| <artifactId>haze</artifactId> | |||
| <version>2.0.1-SNAPSHOT</version> | |||
| <properties> | |||
| <maven.compiler.release>19</maven.compiler.release> | |||
| <maven.compiler.release>21</maven.compiler.release> | |||
There was a problem hiding this comment.
Changing the java version in pom.xml might have some implications for other parts of the code. Both CI pipeline and release pipeline are using java 19 now when building the code.
…com/fungover/haze into 115-refactor-main-OldPullRequst-Fix
fix versions from old pull request
kappsegla
requested changes
Feb 2, 2024
|
Replaced by #182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored Main-class