Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend use of MVP/MVVM/MVI patterns #150

Open
peter-tackage opened this issue Jul 16, 2017 · 3 comments
Open

Recommend use of MVP/MVVM/MVI patterns #150

peter-tackage opened this issue Jul 16, 2017 · 3 comments

Comments

@peter-tackage
Copy link
Contributor

  • The particular pattern being used is not as is the separation of concerns and testability.
  • Encourage keeping Activities and Fragments thin/logic free.
  • Reference Freesound app.
@jflavio11
Copy link

Clean architecture should be the best option and, in my opinion, package structure by feature is not too scalable

@peter-tackage
Copy link
Contributor Author

Clean architecture goes a bit beyond the presentation logic of MVP/MVVM/MVI, it's more of an overall app architecture. At the moment, I'd be tempted to be a little more opinionated and suggest Clean Architecture with MVVM/MVI as the presentation layer.

How would you recommend package structure in a way that was scalable? and what about a feature packaging is not scalable?

@fuhoi
Copy link

fuhoi commented Mar 14, 2018

Long time reader and user of these Android best practice docs but first time commenter. I'm currently working on a project using a Clean variant with MVP and feature packages - it's working well for the current project use cases. It really helps to groups things together and allows our devs to communicate/move across platforms easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants