.github/workflows/platform_tests.yml

@@ -0,0 +1,48 @@
+name: Platform Tests
+on: [push, pull_request]
+
+jobs:
+  platform_tests:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        go-version: [1.12.x, 1.15.x]
+        os: [ubuntu-latest, windows-latest, macos-latest]
+
+    steps:
+    - uses: actions/checkout@v2
+    - uses: actions/setup-go@v2
+      with:
+        go-version: ${{ matrix.go-version }}
+
+    - name: Get dependencies
+      run: sudo apt-get update && sudo apt-get install golang gcc libgl1-mesa-dev libegl1-mesa-dev libgles2-mesa-dev libx11-dev xorg-dev
+      if: ${{ runner.os == 'Linux' }}
+
+    #- name: Verify go modules
+    #  run: |
+    #    if [ "$GO111MODULE" == "on" ]
+    #    then
+    #        # For some reason `git diff-index HEAD` does not work properly if the following line is missing.
+    #        git diff
+    #        # check that go mod tidy does not change go.mod/go.sum
+    #        go mod tidy && git diff-index --quiet HEAD -- || ( echo "go.mod/go.sum not up-to-date"; git diff-index HEAD --; false )
+    #    fi
+
+    - name: Tests
+      run: go test -tags ci ./...
+
+    - name: Update coverage
+      run: |
+        GO111MODULE=off go get github.com/mattn/goveralls
+
+        set -e
+        go test -tags ci -covermode=atomic -coverprofile=coverage.out ./...
+        if [ $coverage -lt 69 ]; then echo "Test coverage lowered"; exit 1; fi
+      if: ${{ runner.os == 'Linux' }}
+
+    - name: Update PR Coverage
+      uses: shogo82148/actions-goveralls@v1
+      with:
+        path-to-profile: coverage.out
+      if: ${{ runner.os == 'Linux' && github.event_name == 'push' }}

.github/workflows/static_analysis.yml

@@ -1,4 +1,3 @@
-
 name: Static Analysis
 on: [push, pull_request]
 

.gitignore

@@ -3,6 +3,10 @@ cmd/fyne/fyne
 cmd/fyne_demo/fyne_demo
 cmd/fyne_settings/fyne_settings
 cmd/hello/hello
+cmd/fyne/fyne.exe
+cmd/fyne_demo/fyne_demo.exe
+cmd/fyne_settings/fyne_settings.exe
+cmd/hello/hello.exe
 
 ### Tests
 **/testdata/failed

CHANGELOG.md

@@ -3,6 +3,23 @@
 This file lists the main changes with each version of the Fyne toolkit.
 More detailed release notes can be found on the [releases page](https://github.com/fyne-io/fyne/releases). 
 
+## 1.4.3 - 4 January 2021
+
+### Fixed
+
+* Fix crash when showing file open dialog on iPadOS
+* Fix possible missing icon on initial show of disabled button
+* Capturing a canvas on macOS retina display would not capture full resolution
+* Fix the release build flag for mobile
+* Fix possible race conditions for canvas capture
+* Improvements to `fyne get` command downloader
+* Fix tree, so it refreshes visible nodes on Refresh()
+* TabContainer Panic when removing selected tab (#1668)
+* Incorrect clipping behaviour with nested scroll containers (#1682)
+* MacOS Notifications are not shown on subsequent app runs (#1699)
+* Fix the behavior when dragging the divider of split container (#1618)
+
+
 ## 1.4.2 - 9 December 2020
 
 ### Added

README.md

@@ -1,6 +1,6 @@
 <p align="center">
   <a href="https://pkg.go.dev/fyne.io/fyne?tab=doc" title="Go API Reference" rel="nofollow"><img src="https://img.shields.io/badge/go-documentation-blue.svg?style=flat" alt="Go API Reference"></a>
-  <a href="https://github.com/fyne-io/fyne/releases/tag/v1.4.2" title="1.4.2 Release" rel="nofollow"><img src="https://img.shields.io/badge/version-1.4.2-blue.svg?style=flat" alt="1.4.2 release"></a>
+  <a href="https://github.com/fyne-io/fyne/releases/tag/v1.4.3" title="1.4.3 Release" rel="nofollow"><img src="https://img.shields.io/badge/version-1.4.3-blue.svg?style=flat" alt="1.4.3 release"></a>
   <a href='http://gophers.slack.com/messages/fyne'><img src='https://img.shields.io/badge/join-us%20on%20slack-gray.svg?longCache=true&logo=slack&colorB=blue' alt='Join us on Slack' /></a>
   <br />
   <a href="https://goreportcard.com/report/fyne.io/fyne"><img src="https://goreportcard.com/badge/fyne.io/fyne" alt="Code Status" /></a>

app/app_darwin.m

@@ -22,8 +22,6 @@ - (BOOL)userNotificationCenter:(NSUserNotificationCenter*)center
 
 @end
 
-static int notifyNum = 0;
-
 void sendNSUserNotification(const char *, const char *);
 
 bool isBundled() {
@@ -40,10 +38,12 @@ void sendNotification(const char *title, const char *body) {
     if (center.delegate == nil) {
         center.delegate = [[FyneUserNotificationCenterDelegate new] autorelease];
     }
+
+    NSString *uuid = [[NSUUID UUID] UUIDString];
     NSUserNotification *notification = [[NSUserNotification new] autorelease];
     notification.title = [NSString stringWithUTF8String:title];
     notification.informativeText = [NSString stringWithUTF8String:body];
-    notification.identifier = [NSString stringWithFormat:@"%@-fyne-notify-%d", [[NSBundle mainBundle] bundleIdentifier], ++notifyNum];
+    notification.identifier = [NSString stringWithFormat:@"%@-fyne-notify-%@", [[NSBundle mainBundle] bundleIdentifier], uuid];
     [center scheduleNotification:notification];
 }
 

cmd/fyne/commands/get.go

@@ -17,7 +17,7 @@ var _ Command = (*Getter)(nil)
 
 // Getter is the command that can handle downloading and installing Fyne apps to the current platform.
 type Getter struct {
-	pkg string
+	icon string
 }
 
 // NewGetter returns a command that can handle the download and install of GUI apps built using Fyne.
@@ -28,8 +28,7 @@ func NewGetter() *Getter {
 
 // Get automates the download and install of a named GUI app package.
 func (g *Getter) Get(pkg string) error {
-	g.pkg = pkg
-	return g.get()
+	return get(pkg, g.icon)
 }
 
 // AddFlags adds available flags to the current flags parser
@@ -49,31 +48,32 @@ func (g *Getter) Run(args []string) {
 		fmt.Fprintln(os.Stderr, "Missing \"package\" argument to define the application to get")
 		os.Exit(1)
 	}
-	g.pkg = args[0]
 
-	err := g.get()
+	err := get(args[0], g.icon)
 	if err != nil {
 		fmt.Fprintf(os.Stderr, "%s\n", err.Error())
 		os.Exit(1)
 	}
 }
 
-func (g *Getter) get() error {
-	path := filepath.Join(goPath(), "src", g.pkg)
+// SetIcon allows you to set the app icon path that will be used for the next Get operation.
+func (g *Getter) SetIcon(path string) {
+	g.icon = path
+}
 
-	cmd := exec.Command("go", "get", "-u", g.pkg)
+func get(pkg, icon string) error {
+	path := filepath.Join(goPath(), "src", pkg)
 
-	out, err := cmd.CombinedOutput()
-	if err != nil {
-		fmt.Fprintf(os.Stderr, "%s\n", string(out))
-		return err
-	}
+	cmd := exec.Command("go", "get", "-u", "-d", pkg)
+	cmd.Env = append(os.Environ(), "GO111MODULE=off")
+
+	_, err := cmd.CombinedOutput()
 
-	if !util.Exists(path) {
-		return errors.New("Package download not found in expected location")
+	if !util.Exists(path) { // the error above may be ignorable, unless the path was not found
+		return err
 	}
 
-	install := &installer{srcDir: path}
+	install := &installer{srcDir: path, icon: icon, release: true}
 	err = install.validate()
 	if err != nil {
 		return errors.Wrap(err, "Failed to set up installer")

cmd/fyne/commands/install.go

@@ -19,6 +19,7 @@ var _ Command = (*installer)(nil)
 type installer struct {
 	installDir, srcDir, icon, os, appID string
 	packager                            *packager
+	release                             bool
 }
 
 // NewInstaller returns an install command that can install locally built Fyne apps.
@@ -31,6 +32,7 @@ func (i *installer) AddFlags() {
 	flag.StringVar(&i.installDir, "installDir", "", "A specific location to install to, rather than the OS default")
 	flag.StringVar(&i.icon, "icon", "Icon.png", "The name of the application icon file")
 	flag.StringVar(&i.appID, "appID", "", "For ios or darwin targets an appID is required, for ios this must \nmatch a valid provisioning profile")
+	flag.BoolVar(&i.release, "release", false, "Should this package be installed in release mode? (disable debug etc)")
 }
 
 func (i *installer) PrintHelp(indent string) {
@@ -139,5 +141,6 @@ func (i *installer) validate() error {
 	}
 	i.packager = &packager{appID: i.appID, os: os, install: true, srcDir: i.srcDir}
 	i.packager.icon = i.icon
+	i.packager.release = i.release
 	return i.packager.validate()
 }

cmd/fyne/internal/mobile/build.go

@@ -321,6 +321,9 @@ func goCmdAt(at string, subcmd string, srcs []string, env []string, args ...stri
 	if targetOS == "darwin" {
 		tags = append(tags, "ios")
 	}
+	if buildRelease {
+		tags = append(tags, "release")
+	}
 	if len(tags) > 0 {
 		cmd.Args = append(cmd.Args, "-tags", strings.Join(tags, " "))
 	}

cmd/fyne_demo/tutorials/collection.go

@@ -5,7 +5,6 @@ import (
 
 	"fyne.io/fyne"
 	"fyne.io/fyne/container"
-	internalWidget "fyne.io/fyne/internal/widget"
 	"fyne.io/fyne/layout"
 	"fyne.io/fyne/theme"
 	"fyne.io/fyne/widget"
@@ -78,17 +77,30 @@ func makeTableTab(_ fyne.Window) fyne.CanvasObject {
 }
 
 func makeTreeTab(_ fyne.Window) fyne.CanvasObject {
-	data := make(map[string][]string)
-	internalWidget.AddTreePath(data, "A", "B", "C", "abc")
-	internalWidget.AddTreePath(data, "A", "D", "E", "F", "adef")
-	internalWidget.AddTreePath(data, "A", "D", "E", "G", "adeg")
-	internalWidget.AddTreePath(data, "A", "H", "I", "ahi")
-	internalWidget.AddTreePath(data, "A", "J", "K", "ajk")
-	internalWidget.AddTreePath(data, "A", "L", "M", "N", "almn")
-	internalWidget.AddTreePath(data, "A", "O", "ao")
-	internalWidget.AddTreePath(data, "A", "P", "Q", "R", "apqr")
-	internalWidget.AddTreePath(data, "A", "S", "T", "U", "astu")
-	internalWidget.AddTreePath(data, "A", "V", "W", "X", "Y", "Z", "avwxyz")
+	data := map[string][]string{
+		"":  {"A"},
+		"A": {"B", "D", "H", "J", "L", "O", "P", "S", "V"},
+		"B": {"C"},
+		"C": {"abc"},
+		"D": {"E"},
+		"E": {"F", "G"},
+		"F": {"adef"},
+		"G": {"adeg"},
+		"H": {"I"},
+		"I": {"ahi"},
+		"O": {"ao"},
+		"P": {"Q"},
+		"Q": {"R"},
+		"R": {"apqr"},
+		"S": {"T"},
+		"T": {"U"},
+		"U": {"astu"},
+		"V": {"W"},
+		"W": {"X"},
+		"X": {"Y"},
+		"Y": {"Z"},
+		"Z": {"avwxyz"},
+	}
 
 	tree := widget.NewTreeWithStrings(data)
 	tree.OnSelected = func(id string) {

go.mod

@@ -7,7 +7,7 @@ require (
 	github.com/akavel/rsrc v0.8.0 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/fsnotify/fsnotify v1.4.9
-	github.com/fyne-io/mobile v0.1.2-0.20201127155338-06aeb98410cc
+	github.com/fyne-io/mobile v0.1.2
 	github.com/go-gl/gl v0.0.0-20190320180904-bf2b1f2f34d7
 	github.com/go-gl/glfw/v3.3/glfw v0.0.0-20200625191551-73d3c3675aa3
 	github.com/godbus/dbus/v5 v5.0.3

go.sum

@@ -10,8 +10,8 @@ github.com/fsnotify/fsnotify v1.4.9 h1:hsms1Qyu0jgnwNXIxa+/V/PDsU6CfLf6CNO8H7IWo
 github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4IgpuI1SZQ=
 github.com/fyne-io/glfw/v3.3/glfw v0.0.0-20201123143003-f2279069162d h1:WfVxpuVm+5Gr3ipAoWrxV8lJFYkaBWoEwFRrWThWRSU=
 github.com/fyne-io/glfw/v3.3/glfw v0.0.0-20201123143003-f2279069162d/go.mod h1:tQ2UAYgL5IevRw8kRxooKSPJfGvJ9fJQFa0TUsXzTg8=
-github.com/fyne-io/mobile v0.1.2-0.20201127155338-06aeb98410cc h1:oNo/EXJa9DurC8zmzWDzBCUV3R/b03SWCW/Qftmgpb0=
-github.com/fyne-io/mobile v0.1.2-0.20201127155338-06aeb98410cc/go.mod h1:/kOrWrZB6sasLbEy2JIvr4arEzQTXBTZGb3Y96yWbHY=
+github.com/fyne-io/mobile v0.1.2 h1:0HaXDtOOwyOTn3Umi0uKVCOgJtfX73c6unC4U8i5VZU=
+github.com/fyne-io/mobile v0.1.2/go.mod h1:/kOrWrZB6sasLbEy2JIvr4arEzQTXBTZGb3Y96yWbHY=
 github.com/go-gl/gl v0.0.0-20190320180904-bf2b1f2f34d7 h1:SCYMcCJ89LjRGwEa0tRluNRiMjZHalQZrVrvTbPh+qw=
 github.com/go-gl/gl v0.0.0-20190320180904-bf2b1f2f34d7/go.mod h1:482civXOzJJCPzJ4ZOX/pwvXBWSnzD4OKMdH4ClKGbk=
 github.com/godbus/dbus/v5 v5.0.3 h1:ZqHaoEF7TBzh4jzPmqVhE/5A1z9of6orkAe5uHoAeME=

internal/clip.go

@@ -0,0 +1,81 @@
+package internal
+
+import "fyne.io/fyne"
+
+// ClipStack keeps track of the areas that should be clipped when drawing a canvas.
+// If no clips are present then adding one will be added as-is.
+// Subsequent items pushed will be completely within the previous clip.
+type ClipStack struct {
+	clips []*ClipItem
+}
+
+// Pop removes the current top clip and returns it.
+func (c *ClipStack) Pop() *ClipItem {
+	if len(c.clips) == 0 {
+		return nil
+	}
+
+	ret := c.clips[len(c.clips)-1]
+	c.clips = c.clips[:len(c.clips)-1]
+	return ret
+}
+
+// Length  returns the number of items in this clip stack. 0 means no clip.
+func (c *ClipStack) Length() int {
+	return len(c.clips)
+}
+
+// Push a new clip onto this stack at position and size specified.
+// The returned clip item is the result of calculating the intersection of the requested clip and it's parent.
+func (c *ClipStack) Push(p fyne.Position, s fyne.Size) *ClipItem {
+	outer := c.Top()
+	inner := outer.Intersect(p, s)
+
+	c.clips = append(c.clips, inner)
+	return inner
+}
+
+// Top returns the current clip item - it will always be within the bounds of any parent clips.
+func (c *ClipStack) Top() *ClipItem {
+	if len(c.clips) == 0 {
+		return nil
+	}
+
+	return c.clips[len(c.clips)-1]
+}
+
+// ClipItem represents a single clip in a clip stack, denoted by a size and position.
+type ClipItem struct {
+	pos  fyne.Position
+	size fyne.Size
+}
+
+// Rect returns the position and size parameters of the clip.
+func (i *ClipItem) Rect() (fyne.Position, fyne.Size) {
+	return i.pos, i.size
+}
+
+// Intersect returns a new clip item that is the intersection of the requested parameters and this clip.
+func (i *ClipItem) Intersect(p fyne.Position, s fyne.Size) *ClipItem {
+	ret := &ClipItem{p, s}
+	if i == nil {
+		return ret
+	}
+
+	if ret.pos.X < i.pos.X {
+		ret.pos.X = i.pos.X
+		ret.size.Width -= i.pos.X - p.X
+	}
+	if ret.pos.Y < i.pos.Y {
+		ret.pos.Y = i.pos.Y
+		ret.size.Height -= i.pos.Y - p.Y
+	}
+
+	if p.X+s.Width > i.pos.X+i.size.Width {
+		ret.size.Width = (i.pos.X + i.size.Width) - ret.pos.X
+	}
+	if p.Y+s.Height > i.pos.Y+i.size.Height {
+		ret.size.Height = (i.pos.Y + i.size.Height) - ret.pos.Y
+	}
+	return ret
+}