Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: fyne-io/fyne
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.1.1
Choose a base ref
...
head repository: fyne-io/fyne
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.1.2
Choose a head ref

Commits on Oct 28, 2021

  1. Copy the full SHA
    5ace18d View commit details
  2. Copy the full SHA
    b757268 View commit details

Commits on Oct 31, 2021

  1. Merge pull request #2594 from andydotxyz/fix/2478

    'Fix' the Sierra build error by adding -tags legacy
    andydotxyz authored Oct 31, 2021
    Copy the full SHA
    729a478 View commit details

Commits on Nov 7, 2021

  1. Copy the full SHA
    cb91a71 View commit details

Commits on Nov 11, 2021

  1. Copy the full SHA
    a35e2ba View commit details
  2. Copy the full SHA
    f764615 View commit details
  3. Copy the full SHA
    6b33dbc View commit details
  4. Better wording for sizes

    Jacalz committed Nov 11, 2021
    Copy the full SHA
    59a5399 View commit details
  5. Copy the full SHA
    94cadda View commit details

Commits on Nov 15, 2021

  1. Copy the full SHA
    324fab8 View commit details
  2. Copy the full SHA
    6f6e01f View commit details
  3. Copy the full SHA
    c0e994b View commit details
  4. Use BasicBinder for label bindings

    nullst authored and andydotxyz committed Nov 15, 2021
    Copy the full SHA
    601bb75 View commit details
  5. Copy the full SHA
    a44cbc8 View commit details
  6. Copy the full SHA
    2b9a41e View commit details
  7. Improved mutex logic in basicBinder

    nullst authored and andydotxyz committed Nov 15, 2021
    Copy the full SHA
    06b2ff2 View commit details
  8. Renamed function to avoid underscore

    nullst authored and andydotxyz committed Nov 15, 2021
    Copy the full SHA
    a8bbaf2 View commit details
  9. Reorder functions alphabetically

    nullst authored and andydotxyz committed Nov 15, 2021
    Copy the full SHA
    8f6de69 View commit details
  10. Copy the full SHA
    241337b View commit details
  11. Copy the full SHA
    1913924 View commit details
  12. Copy the full SHA
    6d870bc View commit details
  13. Copy the full SHA
    1c8e354 View commit details
  14. Copy the full SHA
    c34fb9e View commit details
  15. Copy the full SHA
    4585da6 View commit details
  16. Fix partial child URI returned by storage.List() for content: scheme …

    …on Android
    
    The current implementation only returns the DOCUMENT_ID instead of the
    full URI. Build the child URI using buildDocumentUriUsingTree.
    
    See https://developer.android.com/reference/android/provider/DocumentsContract#buildDocumentUriUsingTree(android.net.Uri,%20java.lang.String)
    
    Fixes #2619
    lugu authored and andydotxyz committed Nov 15, 2021
    Copy the full SHA
    640b699 View commit details
  17. Don't prop open window with selectEntry options width

    This matches the behaviour of Select now.
    Fixes #2641
    andydotxyz committed Nov 15, 2021
    Copy the full SHA
    a01453d View commit details
  18. Copy the full SHA
    1127707 View commit details
  19. Copy the full SHA
    7d75c81 View commit details
  20. Fix formatting, sorry

    andydotxyz committed Nov 15, 2021
    Copy the full SHA
    2ff70b8 View commit details
  21. Remove more unneeded code

    andydotxyz committed Nov 15, 2021
    Copy the full SHA
    d607260 View commit details

Commits on Nov 16, 2021

  1. Copy the full SHA
    4034a08 View commit details

Commits on Nov 19, 2021

  1. Merge pull request #2648 from andydotxyz/fix/2641

    Don't prop open window with selectEntry options width
    andydotxyz authored Nov 19, 2021
    Copy the full SHA
    c4131fe View commit details

Commits on Nov 22, 2021

  1. Copy the full SHA
    65adb47 View commit details
  2. Update go-gl/glfw for OpenBSD support and FreeBSD fix

    This update adds support for building on OpenBSD, a fix to avoid using dynamically linked glfw on FreeBSD and updates glfw to 3.3.4 (contains just a fullscreen fix on X11).
    Fixes #1928
    Jacalz authored and andydotxyz committed Nov 22, 2021
    Copy the full SHA
    705fb84 View commit details
  3. Update vendor

    andydotxyz committed Nov 22, 2021
    Copy the full SHA
    0d987b0 View commit details
  4. Copy the full SHA
    2216c49 View commit details
  5. Merge pull request #2658 from Jacalz/changelog

    A few wording updates for the changelog
    Jacalz authored Nov 22, 2021
    Copy the full SHA
    a2ee1f3 View commit details
  6. Add workaround to use just 1 thread on Apple M1

    Downsize is resize is not as smooth, but upside does not crash.
    
    Fixes #2188
    andydotxyz committed Nov 22, 2021
    Copy the full SHA
    da0f834 View commit details
  7. Update internal/driver/glfw/loop.go

    Co-authored-by: Changkun Ou <hi@changkun.de>
    andydotxyz and changkun authored Nov 22, 2021
    Copy the full SHA
    439fb57 View commit details
  8. Update internal/driver/glfw/loop.go

    Co-authored-by: Changkun Ou <hi@changkun.de>
    andydotxyz and changkun authored Nov 22, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    e71b2d2 View commit details
  9. Copy the full SHA
    1f393ff View commit details
  10. Merge pull request #2659 from andydotxyz/fix/2188

    Add workaround to use just 1 thread on Apple M1
    andydotxyz authored Nov 22, 2021
    Copy the full SHA
    38a6122 View commit details
  11. Copy the full SHA
    fa4c671 View commit details

Commits on Nov 25, 2021

  1. Copy the full SHA
    75a252b View commit details

Commits on Nov 28, 2021

  1. Copy the full SHA
    4c1cc25 View commit details

Commits on Nov 29, 2021

  1. Copy the full SHA
    b18def6 View commit details
  2. Update changelog

    andydotxyz committed Nov 29, 2021
    Copy the full SHA
    26f4cc0 View commit details
  3. Copy the full SHA
    97159e6 View commit details
  4. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    a691fb1 View commit details
  5. Latest items fixed

    andydotxyz committed Nov 29, 2021
    Copy the full SHA
    1b228e6 View commit details
Showing with 863 additions and 369 deletions.
  1. +2 −0 .github/ISSUE_TEMPLATE/config.yml
  2. +1 −0 .github/PULL_REQUEST_TEMPLATE.md
  3. +24 −0 CHANGELOG.md
  4. +1 −1 app/app_darwin.go
  5. +13 −4 app/app_darwin.m
  6. +9 −0 app/app_notlegacy_darwin.go
  7. +1 −3 app/app_xdg.go
  8. +5 −1 cmd/fyne/internal/commands/package.go
  9. +1 −1 cmd/fyne/internal/commands/release.go
  10. +18 −0 cmd/fyne/internal/mobile/binres/binres.go
  11. +1 −0 cmd/fyne_demo/FyneApp.toml
  12. +84 −21 data/binding/bindlists.go
  13. +18 −4 data/binding/gen.go
  14. +6 −1 data/binding/mapbinding.go
  15. +4 −12 dialog/file.go
  16. +2 −2 go.mod
  17. +4 −4 go.sum
  18. +4 −4 internal/driver/common/canvas.go
  19. +2 −0 internal/driver/glfw/driver.go
  20. +35 −18 internal/driver/glfw/loop.go
  21. +2 −2 internal/driver/glfw/menu_darwin.m
  22. +23 −10 internal/driver/glfw/window.go
  23. +22 −0 internal/driver/glfw/window_test.go
  24. +5 −4 internal/driver/mobile/android.c
  25. +0 −2 internal/driver/mobile/canvas.go
  26. +3 −2 internal/painter/image.go
  27. +4 −4 internal/painter/image_internal_test.go
  28. +1 −1 vendor/github.com/go-gl/glfw/v3.3/glfw/GLFW_C_REVISION.txt
  29. +6 −6 vendor/github.com/go-gl/glfw/v3.3/glfw/build.go
  30. +1 −1 vendor/github.com/go-gl/glfw/v3.3/glfw/{c_glfw_freebsd.go → c_glfw_bsd.go}
  31. +8 −1 vendor/github.com/go-gl/glfw/v3.3/glfw/glfw.go
  32. +1 −1 vendor/github.com/go-gl/glfw/v3.3/glfw/glfw/include/GLFW/glfw3.h
  33. +4 −0 vendor/github.com/go-gl/glfw/v3.3/glfw/glfw/src/win32_init.c
  34. +4 −0 vendor/github.com/go-gl/glfw/v3.3/glfw/glfw/src/x11_window.c
  35. +1 −1 vendor/github.com/go-gl/glfw/v3.3/glfw/glfw_tree_rebuild.go
  36. +1 −1 vendor/github.com/go-gl/glfw/v3.3/glfw/native_linbsd.go
  37. +18 −3 vendor/github.com/go-gl/glfw/v3.3/glfw/window.go
  38. +3 −1 vendor/github.com/go-ole/go-ole/idispatch_windows.go
  39. +59 −26 vendor/github.com/go-ole/go-ole/ole.go
  40. +2 −2 vendor/github.com/go-ole/go-ole/safearrayconversion.go
  41. +11 −0 vendor/github.com/go-ole/go-ole/variant_arm.go
  42. +13 −0 vendor/github.com/go-ole/go-ole/variant_arm64.go
  43. +22 −0 vendor/github.com/go-ole/go-ole/variant_date_arm.go
  44. +23 −0 vendor/github.com/go-ole/go-ole/variant_date_arm64.go
  45. +2 −2 vendor/modules.txt
  46. +78 −0 widget/bind_helper.go
  47. +43 −0 widget/bind_helper_test.go
  48. +40 −28 widget/check.go
  49. +28 −7 widget/check_internal_test.go
  50. +43 −31 widget/entry.go
  51. +20 −36 widget/label.go
  52. +29 −13 widget/markdown.go
  53. +31 −8 widget/markdown_test.go
  54. +3 −3 widget/popup.go
  55. +3 −1 widget/popup_menu.go
  56. +21 −24 widget/progressbar.go
  57. +1 −1 widget/radio_item.go
  58. +1 −10 widget/select_entry.go
  59. +5 −31 widget/select_entry_internal_test.go
  60. +43 −30 widget/slider.go
2 changes: 2 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -2,3 +2,5 @@ contact_links:
- name: Ask a question
url: https://fyne.io/support/
about: For a toolkit question or help with your code go to our support page

blank_issues_enabled: false
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -21,3 +21,4 @@ Fixes #(issue)
- [ ] Public APIs match existing style.
- [ ] Any breaking changes have a deprecation path or have been discussed.
- [ ] Updated the vendor folder (using `go mod vendor`).
- [ ] Check for binary size increases when importing new modules.
24 changes: 24 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,30 @@
This file lists the main changes with each version of the Fyne toolkit.
More detailed release notes can be found on the [releases page](https://github.com/fyne-io/fyne/releases).

## 2.1.2 - Ongoing

### Fixed

* Scrolling list bound to data programmatically causes nil pointer dereference (#2549)
* Rich text from markdown can get newlines wrong (#2589)
* Fix crash on 32bit operating systems (#2603)
* Compile failure on MacOS 10.12 Sierra (#2478)
* Don't focus widgets on mobile where keyboard should not display (#2598)
* storage.List doesn't return complete URI on Android for "content:" scheme (#2619)
* Last word of the line and first word of the next line are joined in markdown parse (#2647)
* Support for building `cmd/fyne` on Windows arm64
* Fixed FreeBSD requiring installed glfw library dependency (#1928)
* Apple M1: error when using mouse drag to resize window (#2188)
* Struct binding panics in reload with slice field (#2607)
* File Dialog favourites can break for certain locations (#2595)
* Define user friendly names for Android Apps (#2653)
* Entry validator not updating if content is changed via data binding after SetContent (#2639)
* CenterOnScreen not working for FixedSize Window (#2550)
* Panic in boundStringListItem.Get() (#2643)
* Can't set an app/window icon to be an svg. (#1196)
* SetFullScreen(false) can give error (#2588)


## 2.1.1 - 22 October 2021

### Fixed
2 changes: 1 addition & 1 deletion app/app_darwin.go
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ package app

/*
#cgo CFLAGS: -x objective-c
#cgo LDFLAGS: -framework Foundation -framework UserNotifications
#cgo LDFLAGS: -framework Foundation
#include <stdbool.h>
#include <stdlib.h>
17 changes: 13 additions & 4 deletions app/app_darwin.m
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
// +build !ci

#import <Foundation/Foundation.h>
#if __MAC_OS_X_VERSION_MAX_ALLOWED >= 101400
#import <UserNotifications/UserNotifications.h>
#endif

static int notifyNum = 0;

extern void fallbackSend(char *cTitle, char *cBody);

bool isBundled() {
return [[NSBundle mainBundle] bundleIdentifier] != nil;
}

#if __MAC_OS_X_VERSION_MAX_ALLOWED >= 101400
void doSendNotification(UNUserNotificationCenter *center, NSString *title, NSString *body) {
UNMutableNotificationContent *content = [UNMutableNotificationContent new];
[content autorelease];
@@ -24,10 +32,6 @@ void doSendNotification(UNUserNotificationCenter *center, NSString *title, NSStr
}];
}

bool isBundled() {
return [[NSBundle mainBundle] bundleIdentifier] != nil;
}

void sendNotification(char *cTitle, char *cBody) {
UNUserNotificationCenter *center = [UNUserNotificationCenter currentNotificationCenter];
NSString *title = [NSString stringWithUTF8String:cTitle];
@@ -49,3 +53,8 @@ void sendNotification(char *cTitle, char *cBody) {
}
}];
}
#else
void sendNotification(char *cTitle, char *cBody) {
fallbackSend(cTitle, cBody);
}
#endif
9 changes: 9 additions & 0 deletions app/app_notlegacy_darwin.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// +build !ci
// +build !legacy

package app

/*
#cgo LDFLAGS: -framework Foundation -framework UserNotifications
*/
import "C"
4 changes: 1 addition & 3 deletions app/app_xdg.go
Original file line number Diff line number Diff line change
@@ -46,9 +46,7 @@ func (a *fyneApp) SendNotification(n *fyne.Notification) {
}

func rootConfigDir() string {
homeDir, _ := os.UserHomeDir()

desktopConfig := filepath.Join(homeDir, ".config")
desktopConfig, _ := os.UserConfigDir()
return filepath.Join(desktopConfig, "fyne")
}

6 changes: 5 additions & 1 deletion cmd/fyne/internal/commands/package.go
Original file line number Diff line number Diff line change
@@ -167,7 +167,11 @@ func (p *Packager) Package() error {
return err
}

err = p.doPackage()
return p.packageWithoutValidate()
}

func (p *Packager) packageWithoutValidate() error {
err := p.doPackage()
if err != nil {
return err
}
2 changes: 1 addition & 1 deletion cmd/fyne/internal/commands/release.go
Original file line number Diff line number Diff line change
@@ -189,7 +189,7 @@ func (r *Releaser) releaseAction(_ *cli.Context) error {
return err
}

err := r.Packager.Package()
err := r.Packager.packageWithoutValidate()
if err != nil {
return err
}
18 changes: 18 additions & 0 deletions cmd/fyne/internal/mobile/binres/binres.go
Original file line number Diff line number Diff line change
@@ -467,6 +467,24 @@ func resolveElements(elms []*Element, pool, bxPool *Pool) {
sort.Sort(byType(el.attrs))
sort.Sort(byNamespace(el.attrs))
sort.Sort(byName(el.attrs))

if el.Name.Resolve(bxPool) == "application" {
// The android manifest seems to be very delicate - though it may be code in this package
// set the order very carefully... #2653 and others
sort.Slice(el.attrs, func(i, j int) bool {
a := el.attrs[i].Name.Resolve(bxPool)
if a == "configChanges" || a == "debuggable" {
return false
}
if a == "label" {
return true
}

b := el.attrs[j].Name.Resolve(bxPool)
return a < b
})
}

for _, child := range el.Children {
asort(child)
}
1 change: 1 addition & 0 deletions cmd/fyne_demo/FyneApp.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[Details]
Icon = "../../theme/icons/fyne.png"
Name = "Fyne Demo"
ID = "io.fyne.demo"
Build = 6
Loading