Make file filter case-insensitive #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andydotxyz
requested changes
Jul 12, 2020
|
I added a test for it as you wanted. Should be ready for a re-review now 🙂 |
Curently, a file filter set as ".jpg" would not pick up and files that was saved using ".JPG". This updates the filter to use strings.EqualFold() for case-insensitive lookup.
andydotxyz
approved these changes
Jul 19, 2020
andydotxyz
requested changes
Jul 19, 2020
storage/filter_test.go
Outdated
| assert.NotNil(t, filter) | ||
| assert.Equal(t, true, filter.Matches(storage.NewURI("content:///otherapp/something/pic.JPG"))) | ||
| assert.Equal(t, true, filter.Matches(storage.NewURI("content:///otherapp/something/pic.jpg"))) | ||
|
|
There was a problem hiding this comment.
Some travis notes report this has stray whitespace :(
andydotxyz
approved these changes
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, a file filter set as ".jpg" would not pick up and files that was saved using ".JPG". This updates the filter to use strings.EqualFold() for case-insensitive lookup.
Checklist:
fyne_demo.