Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog filter the dir name start with . #1235

Closed
godcong opened this issue Aug 5, 2020 · 4 comments · Fixed by #1236
Closed

dialog filter the dir name start with . #1235

godcong opened this issue Aug 5, 2020 · 4 comments · Fixed by #1236

Comments

@godcong
Copy link
Contributor

godcong commented Aug 5, 2020

Describe the bug:

In the windows home directory
There are many directories starting with .
But dialog will filter it with a blank name

This is the screenshot about the problems
dialog

The real names are these:
image

godcong added a commit to godcongdev/fyne that referenced this issue Aug 5, 2020
@godcong godcong mentioned this issue Aug 5, 2020
5 tasks
@Jacalz
Copy link
Member

Jacalz commented Aug 5, 2020

The issue template is there for us to more easily be able to help out with solving issues. Thus it should be filled out as much as possible to give more detail into what can be wrong. Please do so and use it in the future 🙂

godcong added a commit to godcongdev/fyne that referenced this issue Aug 5, 2020
andydotxyz added a commit to andydotxyz/fyne that referenced this issue Aug 5, 2020
@andydotxyz
Copy link
Member

I put a fix that applies to folders and files in 88eb229 - it's on release//v1.3.3 branch if you're interested in testing...

@godcong
Copy link
Contributor Author

godcong commented Aug 5, 2020

I put a fix that applies to folders and files in 88eb229 - it's on release//v1.3.3 branch if you're interested in testing...

There are some directories generated by goland under my screenshot, like this:
.GoLand2019.2
Your plan will filter out its ending, and then become like this:
.GoLand2019

andydotxyz pushed a commit that referenced this issue Aug 5, 2020
@andydotxyz
Copy link
Member

Merged the two different changes to this bug, issue resolved on release/v1.3.3 branch ready for release.
directory names now preserved, but filenames fixed. Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants