Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure tab children are resized before being shown #1331

Merged
merged 1 commit into from Sep 21, 2020
Merged

Ensure tab children are resized before being shown #1331

merged 1 commit into from Sep 21, 2020

Conversation

stuartmscott
Copy link
Member

Description:

TabContainer calls Show before calling Resize, resulting in content being laid out with 0x0 size.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style.
  • Any breaking changes have a deprecation path or have been discussed.

@andydotxyz
Copy link
Member

Nice catch, subtle!

@stuartmscott stuartmscott merged commit 5ba08c1 into fyne-io:develop Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stuartmscott @andydotxyz