Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select area is not shown when the menu is opened in the entry #1354

Closed
lusingander opened this issue Oct 2, 2020 · 3 comments
Closed

Select area is not shown when the menu is opened in the entry #1354

lusingander opened this issue Oct 2, 2020 · 3 comments
Assignees
@toaster
Labels
blocker Items that would block a forthcoming release bug Something isn't working
Milestone
1.4 - List, Table...

Comments

@lusingander
Copy link
Contributor

Describe the bug:

If the menu is opened while area is selected in the entry, the selected area is not shown.
(It is only display and the selection area information does not disappear.)
I think that this is not the expected behavior.

#1318 made to occur by.

To Reproduce:

Steps to reproduce the behaviour:

  1. Select strings in the entry.
  2. Right click to open the menu.

Screenshots:

201002

Example code:

Device (please complete the following information):

  • OS: macOS
  • Version: 10.15.6
  • Go version: 1.13.4
  • Fyne version: latest develop (a67eb2f)
@toaster
Copy link
Member

toaster commented Oct 3, 2020

I think the bug here is that the entry does not show the selection unless it has focus.
IMO it should still show the selection but maybe in a somewhat less prominent colour.

@andydotxyz andydotxyz added bug Something isn't working blocker Items that would block a forthcoming release labels Oct 4, 2020
@toaster toaster self-assigned this Oct 6, 2020
@toaster
Copy link
Member

toaster commented Oct 6, 2020

We decided that it is wrong to call FocusLost on a focus manager switch.
I’ve got a fix in queue.

toaster added a commit to toaster/fyne that referenced this issue Oct 6, 2020
@toaster
fix fyne-io#1354: switching overlays no longer removes focus from pre…
fbb11d6 
…vious focus manager

Thus the focused element in the content stays highlighted while a pop-up
menu is opened. Also the focused element stays highlighted if the menu
is opened.
However, the _one_ focus for keyboard events is moved to the overlay on top.
@toaster toaster mentioned this issue Oct 6, 2020
Merged
3 tasks
toaster added a commit that referenced this issue Oct 7, 2020
@toaster
Merge pull request #1363 from toaster/bugfix/1354
e52a719 
fix #1354: switching overlays no longer removes focus from previous f…
@andydotxyz
Copy link
Member

Resolved on the develop branch (where it was noticed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toaster toaster

Labels
blocker Items that would block a forthcoming release bug Something isn't working
Projects
None yet
Milestone
1.4 - List, Table, Tree, Input Valida...
Development

No branches or pull requests
3 participants
@toaster @andydotxyz @lusingander