Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tree Flickering #1488

Merged
merged 1 commit into from Nov 1, 2020
Merged

Fix Tree Flickering #1488

merged 1 commit into from Nov 1, 2020

Conversation

stuartmscott
Copy link
Member

Description:

Update Tree node after updating dev content

Fixes #1465

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style.
  • Any breaking changes have a deprecation path or have been discussed.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and a logical fix, but I'd like to know from someone who can replicate the problem whether it fixes it.

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great step in the right direction. It gets rid of flicker to about 95%, but I have been seeing a few smaller flickers. I am going to approve as it is a very minor change that makes it much better, though there might be more work to be done in this regard.

@stuartmscott stuartmscott merged commit e17a371 into fyne-io:develop Nov 1, 2020
@stuartmscott stuartmscott deleted the fix/1465 branch November 1, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants