iOS: Missing CFBundleIconName and asset catalog

[MagicalTux]

Describe the bug:

When building for iOS and deploying an app, an error is returned by Apple:

ITMS-90713: Missing Info.plist value - A value for the Info.plist key 'CFBundleIconName' is missing in the bundle '...'. Apps built with iOS 11 or later SDK must supply app icons in an asset catalog and must also provide a value for this Info.plist key. For more information see http://help.apple.com/xcode/mac/current/#/dev10510b1f7.

This issue was found while working on issue #1497

To Reproduce:

Steps to reproduce the behaviour:

1. Build for iOS
2. Deploy
3. Email from Apple will arrive with the error message

Device (please complete the following information):

• OS: MacOS
• Version: 10.15.7
• Go version: 1.15.3
• Fyne version: 2d9a597

[MagicalTux]

Looking at another project the following is found:

project.pbxproj file contains the following line under buildSettings:

ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;

A folder Assets.xcassets/AppIcon.appiconset exists containing:

• Icon png files in various sizes
• Contents.json file:

{
  "images" : [
    {
      "size" : "20x20",
      "idiom" : "iphone",
      "filename" : "Icon-App-20x20@2x.png",
      "scale" : "2x"
    },
    ....
  ],
  "info" : {
    "version" : 1,
    "author" : "xcode"
  }
}

[MagicalTux]

Additionally, found in project.pbxproj under objects:

/* Begin PBXBuildFile section */
97C146FE1CF9000F007C117D /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FD1CF9000F007C117D /* Assets.xcassets */; };
...
/* Begin PBXFileReference section */
97C146FD1CF9000F007C117D /* Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Assets.xcassets; sourceTree = "<group>"; };

under children:

97C146FD1CF9000F007C117D /* Assets.xcassets */,

under PBXResourcesBuildPhase files:

97C146FE1CF9000F007C117D /* Assets.xcassets in Resources */,

[andydotxyz]

This is great help thanks. I guess we'd need to make sure that the idiom and scale are set correctly for 4 required icon files that we bundle?

[MagicalTux]

The following idiom/sizes are present in my example:

• iphone
  • 20x20 2x 3x
  • 29x29 1x 2x 3x
  • 40x40 2x 3x
  • 60x60 2x 3x
• ipad
  • 20x20 1x 2x
  • 29x29 1x 2x
  • 40x40 1x 2x
  • 76x76 1x 2x
  • 83.5x83.5 2x
• ios-marketing
  • 1024x1024 1x

The png file has the scale applied (for example 20x20@2x will be a 40x40 png file)

[andydotxyz]

These hints are cracking thanks so much @MagicalTux - I have a proof of concept asset compiler locally and running through the various verification / upload steps now.

[andydotxyz]

OK! I hit some bitcode issues, but this is now working :)

[andydotxyz]

Merged in release/v1.4.x ready for next point release :)