Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil reference in disabled buttons #1558

Merged
merged 1 commit into from Nov 16, 2020
Merged

Fix nil reference in disabled buttons #1558

merged 1 commit into from Nov 16, 2020

Conversation

andydotxyz
Copy link
Member

Also fixes issues with disabled handling in button and select_entry
.
Fixes #1553

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Fix nil reference in disabled buttons
fefe218 
Also fixes issues with disabled handling in button and select_entry
.
Fixes fyne-io#1553
Jacalz
Jacalz approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@andydotxyz andydotxyz merged commit 20d79d9 into fyne-io:release/v1.4.x Nov 16, 2020
@andydotxyz andydotxyz deleted the fix/1553 branch November 16, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andydotxyz @Jacalz